Most of transitions do not respect non translucent navigation bar leading to glitches and wrong frames.

[mikhailmulyar]

When using some transition animations with push, if the Navigation bar set to translucent=false. The following transitions are not working properly:

• Flip
• Explode
• Card
• Turn
• Fold

There are no problems for present transition or if Navigation bar set to translucent=true.

----- Original message ------
Hi. When navigation controller uses opaque navigation bar, translucent=false most of the transitions end up with the wrong frame for destination view, not respecting navigation bar height and UIViewControllerContextTransitioning finalFrameForViewController method.
In most cases like in Fade animation, final frame for view just wrong.
In several cases like in Flip animation it leads to UI jumps and glitches.
In rare cases like Turn left and right animation(not top and bottom, those also have glitches) it works as expected.

[JakeLin]

@mikhailmulyar thanks for reporting this issue, how do you use these animators? We recommend you use them in Apple's way like #242 when you use them in code.

[mikhailmulyar]

I use them in code, but this issues happens in all cases.This issue is reproduces in your Example project, if you go to playground part, to Transitions.storyboard and set navigation bar to non translucent.

[JakeLin]

@mikhailmulyar thanks for your reply, we are busy on swift3 branch at that moment. Please let me know if you have any initial idea how to fix them. I haven't done a deep look, hopefully, it's as simple as calling initialFrameForViewController:fromVC and finalFrameForViewController and set the Rect of the views. A PR will be appreciated 😉

[JakeLin]

@mikhailmulyar I have a look at Flip, it is not that simple. There is some issue with createSnapshots to calculate the frame. But I haven't found a solution yet.

[mikhailmulyar]

I have checked all transitions, more than half of them are easy to fix, like all system. But other will require some time to fix, like Flip and Fold

[JakeLin]

@mikhailmulyar thanks for looking at this issue, if you would like to help me out with this, don't need to fix them in one PR. You can PR them bit by bit. We are about to merge swift3 into master, would you like to work on swift3 (future master) or current master (will be swift2.3), it is up to you? Please let me know if you have any questions.

[mikhailmulyar]

Added PR #309 for Card, Fade, NatGeo, Slide and all System animations

[tbaranes]

I catch up the discussion you started in #309. I search a bit about why the transitions are broken. I have no explanation, but the transitions are working as expected on the iPhone 6 simulator but broken on the iPhone 7. Any idea what's difference could be have between both?

Also, it's definitely the resizableSnapshotView which is broken, but not sure how we could replace it.

[tbaranes]

Should we really close this? There's still a few bugs related 🙃

[JakeLin]

@tbaranes I don't think we should close this issue. I closed it when I merged the PR.