Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature meta-tests to cover standard.json #102

Open
andylolz opened this issue Feb 3, 2019 · 2 comments
Open

Add feature meta-tests to cover standard.json #102

andylolz opened this issue Feb 3, 2019 · 2 comments

Comments

@andylolz
Copy link
Contributor

andylolz commented Feb 3, 2019

There are currently meta-tests for rules (which can be thought of as unit tests.)

standard.json could also be covered by meta-tests (which could be thought of as feature tests.)

@samuele-mattiuzzo
Copy link
Contributor

Even better, would be nice if our meta-test xml examples reflected the structure of standard.json (the good/bad split is decent enough and can be kept) so that the official Ruleset document is constantly kept tested (and we won't require double intervention if an existing rule changes slightly in logic, by updating both standard.json and rule_name_test_example.json)

@andylolz
Copy link
Contributor Author

andylolz commented Feb 4, 2019

You’re right – that would be better!

But additionally, would be cool to ensure standard.json is valid somehow. I had a go at this just here, but I don’t know if that’s of interest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants