Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 7.4 Breaks UI #234

Closed
klaxian opened this issue Dec 23, 2019 · 2 comments
Closed

PHP 7.4 Breaks UI #234

klaxian opened this issue Dec 23, 2019 · 2 comments

Comments

@klaxian
Copy link
Collaborator

klaxian commented Dec 23, 2019

Upgrading to PHP 7.4 breaks the UI. Frames are in the wrong place and it is unusable. There is probably a new warning or error preventing everything from being rendered correctly.
@ffflabs
Copy link
Collaborator

ffflabs commented Jan 6, 2020

It seems related to an open issue in php console
barbushin/php-console#165

I'll check if it's easy to remove said dependency. However, composer complained a lot too, and I'm afraid other things might be broken on 7.4.

@ffflabs
Copy link
Collaborator

ffflabs commented Jan 7, 2020

@klaxian I refactored quite a bit and released as v6.0.0-RC1.
(the important part was leaving PHP-Console aside for PHP_VERSION>=7.4)

@ffflabs ffflabs closed this as completed Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ffflabs @klaxian