Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't checkout Homebrew/brew master for non-developers #829

Closed
Bo98 opened this issue Dec 11, 2023 · 2 comments
Closed

Don't checkout Homebrew/brew master for non-developers #829

Bo98 opened this issue Dec 11, 2023 · 2 comments

Comments

@Bo98
Copy link
Member

Bo98 commented Dec 11, 2023

Currently we check out master when cloning Homebrew/brew:

execute "${USABLE_GIT}" "reset" "--hard" "origin/master"

brew update will correct this to be on a stable tag, but picking master initially is not ideal because it means brew update will perform a downgrade and we don't test downgrades (but will accept fixes where there are issues). An example of an issue caused by a downgrade is #825.

Instead, short of a full stable-branch setup that brew update does, an initial detached tag checkout would be much better. Detached tag checkouts without a stable branch now work without downgrades since Homebrew/brew@2a02038.

@MikeMcQuaid
Copy link
Member

Agreed, thanks @Bo98!

osalbahr added a commit to osalbahr/install that referenced this issue Mar 4, 2024
@MikeMcQuaid
Copy link
Member

Fixed by #839

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants