workflows/triage: skip recursive dependents for systemd
#201157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cho-m
added
the
maintainer feedback
github-actions
bot
added
automerge-skip
SMillerDev
approved these changes
Dec 14, 2024
cho-m
force-pushed
the
systemd-skip-recursive
branch
from
4374400 to
ea0fb91
Compare
|
Also removing self-hosted Linux. There are only 50 formulae with dependency and prior runs worked. I think recursive run hits around 500 formulae. |
daeho-ro
approved these changes
Dec 15, 2024
cho-m
removed
the
maintainer feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?We have defined all dependents with linkage to
systemdas direct based on a prior run https://github.com/Homebrew/homebrew-core/actions/runs/12086331739/job/33706038266 (linkage failures are for other formulae).Recursive dependents bring testing time up to 1d10h so would help to only test the direct dependents.
Not sure if there are any runtime dlopen or
systemdexecutables we need to worry about. Though part of goal for the indirect dependencies check is to make theCI-skip-recursive-dependentsthe default behavior anyways.