Skip to content

cfitsio: fix .pc generation #212128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 24, 2025
Merged

cfitsio: fix .pc generation #212128

merged 2 commits into from
Mar 24, 2025

Conversation

gromgit
Copy link
Contributor

@gromgit gromgit commented Mar 20, 2025

Also use pkg-config in test to catch regressions.

Resolves #212112.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@cho-m
Copy link
Member

cho-m commented Mar 20, 2025

This has been fixed upstream:

@gromgit gromgit force-pushed the cfitsio/fix-pc branch 2 times, most recently from c51146b to 6e8dcce Compare March 20, 2025 15:44
@github-actions GitHub Actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Mar 21, 2025
@BrewTestBot BrewTestBot enabled auto-merge March 21, 2025 02:42
auto-merge was automatically disabled March 21, 2025 02:49

Head branch was pushed to by a user without write access

@chenrui333 chenrui333 added this pull request to the merge queue Mar 21, 2025
@chenrui333 chenrui333 removed this pull request from the merge queue due to a manual request Mar 21, 2025
@chenrui333 chenrui333 removed the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Mar 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Bottle publish failed.

@jcupitt jcupitt mentioned this pull request Mar 22, 2025
Closed
@DarrenGrant-Storycraft DarrenGrant-Storycraft mentioned this pull request Mar 22, 2025
Closed
4 tasks
@github-actions GitHub Actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Bottle publish failed.

@gromgit
Copy link
Contributor Author

gromgit commented Mar 23, 2025

Is there something that needs to be fixed with bottle publishing?

@daeho-ro
Copy link
Member

There was a bottle commit and it is removed but the bottle is actually published with the same name.

@carlocab Sorry to bother you again, but here we need help.

@matnich89

This comment was marked as off-topic.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Bottle publish failed.

@gromgit @fxcoudert
cfitsio: fix .pc generation
d380e40 
Also use pkg-config in test to catch regressions.

Resolves Homebrew#212112.
@fxcoudert
Copy link
Member

Actually, since we ship modified files, a revision bump makes sense.

@github-actions GitHub Actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Mar 24, 2025
@BrewTestBot BrewTestBot enabled auto-merge March 24, 2025 17:39
@BrewTestBot BrewTestBot added this pull request to the merge queue Mar 24, 2025
Merged via the queue into Homebrew:master with commit b6b97ac Mar 24, 2025
14 checks passed
@gromgit gromgit deleted the cfitsio/fix-pc branch March 25, 2025 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

@fxcoudert fxcoudert fxcoudert approved these changes

@daeho-ro daeho-ro daeho-ro approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@p-linnane p-linnane p-linnane approved these changes

Assignees
No one assigned
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cfitsio .pc file makes bad cflags
8 participants
@gromgit @cho-m @daeho-ro @matnich89 @fxcoudert @chenrui333 @p-linnane @BrewTestBot