Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/tests: add step names #201446

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

samford
Copy link
Member

@samford samford commented Dec 16, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This adds step names in areas where we recently made changes to the tests.yml workflow. Without a name value, the first line of run is used, which is the shellcheck comments in these areas. Using an explicit name makes it easier to identify these steps at a glance.

This adds step names in areas where we recently made changes to the
`tests.yml` workflow. Without a `name` value, the first line of `run`
is used, which is the `shellcheck` comments in these areas. Using an
explicit name makes it easier to identify these steps at a glance.
@samford samford requested review from MikeMcQuaid and a team as code owners December 16, 2024 23:55
@github-actions github-actions bot added workflows PR modifies GitHub Actions workflow files automerge-skip `brew pr-automerge` will skip this pull request and removed workflows PR modifies GitHub Actions workflow files labels Dec 16, 2024
Copy link
Member

@daeho-ro daeho-ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was annoying really 😂

@ZhongRuoyu ZhongRuoyu added this pull request to the merge queue Dec 17, 2024
Merged via the queue into master with commit 864efb9 Dec 17, 2024
22 checks passed
@ZhongRuoyu ZhongRuoyu deleted the worksflow-tests-add-step-names branch December 17, 2024 02:05
@MikeMcQuaid
Copy link
Member

Great idea, thanks @samford!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants