-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rip2 0.9.0 (new formula) #196052
base: master
Are you sure you want to change the base?
rip2 0.9.0 (new formula) #196052
Conversation
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
thanks for fast reply. Resolved the issues indicated above. |
263f3c9
to
c5326e3
Compare
7c70ec3
to
e5b558a
Compare
e5b558a
to
a5e1c06
Compare
Okay, changes above should be fixed. It is failing on CI for audit it seems. |
a5e1c06
to
d1b61e9
Compare
Formula/r/rip2.rb
Outdated
(buildpath/"rip.bash").write Utils.safe_popen_read(bin/"rip", "completions", "bash") | ||
(buildpath/"rip.fish").write Utils.safe_popen_read(bin/"rip", "completions", "fish") | ||
(buildpath/"_rip").write Utils.safe_popen_read(bin/"rip", "completions", "zsh") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can use generate_completions_from_executable(bin/"rip", "completion")
for these three
since rip (aka rm-improved) is not maintainable, we can do something like rip@1 and rip kind of thing (which we did with gdrive #154959), this way, we dont need to include conflicts resolution. |
provides maintained version of rip under new rip2 name Signed-off-by: Rui Chen <[email protected]>
d1b61e9
to
de1c53a
Compare
never mind, it is not quite applicable in here:
|
provides maintained version of rip under new rip2 name with new features.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?It fails
no fork
but otherwise passes. As mentioned the original rip repo has not been maintained since 2020 and was previously listed under rm-improved orrip
names.