Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffmpeg: add indirect dependencies #171793

Closed
wants to merge 1 commit into from
Closed

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Spotted in #171740.

@carlocab carlocab added CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-no-bottles Merge without publishing bottles labels May 15, 2024
@bevanjkay
Copy link
Member

I have similar open here - #171792
Happy for you to decide which is better and close.

@carlocab
Copy link
Member Author

Weird, didn't show up in a search. Thanks!

@carlocab carlocab closed this May 15, 2024
@carlocab carlocab deleted the ffmpeg-indirect-deps branch May 15, 2024 14:39
@bevanjkay
Copy link
Member

We opened them in the same minute, so I'll forgive you ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles CI-skip-dependents Pass --skip-dependents to brew test-bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants