-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manim: add linked indirect dependencies #171786
Conversation
04a8d0f
to
3581b4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still remaining indirect deps.
On Linux:
Indirect dependencies with linkage:
fontconfig
gcc
glib
jpeg-turbo
libtiff
openblas
pango
zlib
On Intel macOS:
Indirect dependencies with linkage:
libxcb
pango
I'd add these to all macOS, though, since they're already in the dep tree anyway.
The other ones showed extra Linux deps on the rebuild run too. I'll update it in a couple of hours. |
@carlocab I have added the extras, put |
Actually, the There are a bunch that duplicate formulae that are already declared as dependencies (e.g. We should also just use the |
|
That might be another reason, but the problems about duplicating formulae dependencies aren't really fixed by |
Tried fixing it up a bit. Hopefully it works. 🤞 |
fc46a90
to
fc7ca95
Compare
Co-authored-by: Carlo Cabrera <[email protected]>
on_macos do | ||
depends_on "gettext" | ||
depends_on "harfbuzz" | ||
end | ||
|
||
on_linux do | ||
depends_on "cmake" => :build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needing cmake
here is kinda suspicious, ngl
🤖 An automated task has requested bottles to be published to this PR. |
Thanks for finishing this up @carlocab |
some followup PR, #177164 |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?Seen in: https://github.com/Homebrew/homebrew-core/actions/runs/9094160676?pr=171740