Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sui 1.25.0 #171726

Closed
Closed

Conversation

johnjmartin
Copy link
Contributor

@github-actions github-actions bot added rust Rust use is a significant feature of the PR or issue CI-linux-self-hosted Build on Linux self-hosted runner labels May 14, 2024
@chenrui333
Copy link
Member

  error: could not compile `sui` (bin "sui") due to 1 previous error
  error: failed to compile `sui v1.25.0 (/private/tmp/sui-20240514-8180-1vdlvm/sui-testnet-v1.25.0/crates/sui)`, intermediate artifacts can be found at `/private/tmp/sui-20240514-8180-1vdlvm/sui-testnet-v1.25.0/target`.

@carlocab
Copy link
Member

  error[E0080]: evaluation of constant value failed
    --> crates/sui/src/main.rs:12:1
     |
  12 | bin_version::bin_version!();
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ the evaluated program panicked at 'unable to query git revision', crates/sui/src/main.rs:12:1
     |
     = note: this error originates in the macro `$crate::panic::panic_2021` which comes from the expansion of the macro `bin_version::bin_version` (in Nightly builds, run with -Z macro-backtrace for more info)
  
  note: erroneous constant encountered
    --> crates/sui/src/main.rs:12:1
     |
  12 | bin_version::bin_version!();
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = note: this note originates in the macro `bin_version::bin_version` (in Nightly builds, run with -Z macro-backtrace for more info)
  
  note: erroneous constant encountered
    --> crates/sui/src/main.rs:12:1
     |
  12 | bin_version::bin_version!();
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = note: this note originates in the macro `$crate::to_str` which comes from the expansion of the macro `bin_version::bin_version` (in Nightly builds, run with -Z macro-backtrace for more info)

@johnjmartin
Copy link
Contributor Author

Thank you both! i found the problematic change and am fixing forward

johnjmartin added a commit to MystenLabs/sui that referenced this pull request May 15, 2024
## Description 

#17478 breaks our homebrew
releases
(Homebrew/homebrew-core#171726 (comment)),
as it reversed the changes made in
#15727.

## Test plan 

```
$ mv .git .notgit
$ cargo install --path crates/sui
$ /Users/johnmartin/.cargo/bin/sui -V                                                                                                                                                           sui 1.26.0
```
@johnjmartin
Copy link
Contributor Author

Fixed, will be applied with our next release on monday/tuesday

@johnjmartin johnjmartin deleted the update-sui.rb-1715729969 branch May 15, 2024 21:05
ebmifa pushed a commit to MystenLabs/sui that referenced this pull request May 15, 2024
## Description 

#17478 breaks our homebrew
releases
(Homebrew/homebrew-core#171726 (comment)),
as it reversed the changes made in
#15727.

## Test plan 

```
$ mv .git .notgit
$ cargo install --path crates/sui
$ /Users/johnmartin/.cargo/bin/sui -V                                                                                                                                                           sui 1.26.0
```
@johnjmartin johnjmartin restored the update-sui.rb-1715729969 branch May 15, 2024 23:53
gofmanaa pushed a commit to Mamoru-Foundation/sui that referenced this pull request May 20, 2024
## Description 

MystenLabs#17478 breaks our homebrew
releases
(Homebrew/homebrew-core#171726 (comment)),
as it reversed the changes made in
MystenLabs#15727.

## Test plan 

```
$ mv .git .notgit
$ cargo install --path crates/sui
$ /Users/johnmartin/.cargo/bin/sui -V                                                                                                                                                           sui 1.26.0
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-linux-self-hosted Build on Linux self-hosted runner rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants