gensio 2.8.4 (new formula) ser2net: update to use gensio formula

[cminyard]

• [ x] Have you followed the guidelines for contributing?
• [ x] Have you ensured that your commits follow the commit style guide?
• [ x] Have you checked that there aren't other open pull requests for the same formula update/change?
• [ x] Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• [ x] Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• [ x] Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

I submitted this earlier, before gensio had enough likes and forks. It now does. All audits pass.

The ser2net formula builds gensio as part of its build, but gensio is a separate stand-alone library and set of tools. This commit splits gensio into its own separate formula so it can be properly maintained, and makes ser2net depend on that.

As well, the ser2net formula was non-functional. It had the following issues:

• The configuration files were set to inside the /opt/homebrew/etc/ser2net, so every time you upgraded you would lose your configuration. This change moved it to /opt/homebrew/etc/ser2net.

• Same problem with the authentication token location, that is moved to /opt/homebrew/share.

• The service was run in the background, so that caused all kinds of confusion. This switches it to run in the foreground so brew can manage it.

• The administration interface was enabled on the command line. This has security implications and is generally a bad idea outside of testing. The admin interface can be enabled in the configuration files with the proper authentication.

[cminyard]

On Tue, Apr 16, 2024 at 06:13:05AM -0700, Sean Molenaar wrote: @SMillerDev commented on this pull request. > @@ -0,0 +1,49 @@ +class Gensio < Formula + desc "Stream I/O Library" + homepage "https://github.com/cminyard/gensio" + url "https://downloads.sourceforge.net/project/ser2net/ser2net/gensio-2.8.4.tar.gz" Is there no GitHub release?

There is a tag on GitHub, but traditionally I release the tarballs on sourceforge because it's been there a long time and that's where everyone expects it. I can add it to GitHub, if you like.

[SMillerDev]

There is a tag on GitHub, but traditionally I release the tarballs on sourceforge because it's been there a long time and that's where everyone expects it. I can add it to GitHub, if you like.

If the homepage is GitHub I would expect the code to also come from there. If there is a tag we can just download the tarball from there.

[cminyard]

On Tue, Apr 16, 2024 at 06:12:49AM -0700, Sean Molenaar wrote: @SMillerDev commented on this pull request. > system "./configure", "--disable-dependency-tracking", "--prefix=#{prefix}", ```suggestion system "./configure", *std_configure_args ```

Yes, that's better. That's in the ser2net formula, which I didn't originally write, so I just didn't change it.

> + depends_on ***@***.***" + depends_on "portaudio" + depends_on ***@***.***" + depends_on "tcl-tk" + on_linux do + depends_on "alsa-lib" + depends_on "avahi" + depends_on "linux-pam" + end + + def python3 + "python3.11" + end + + def install + # https://rubydoc.brew.sh/Formula.html#std_configure_args-instance_method No need to document what parts of brew a formula is using ```suggestion ```

Ok, I removed the comment. I think that came from boilerplate, but I don't remember.

> + depends_on "alsa-lib" + depends_on "avahi" + depends_on "linux-pam" + end + + def python3 + "python3.11" + end + + def install + # https://rubydoc.brew.sh/Formula.html#std_configure_args-instance_method + system "./configure", *std_configure_args, + "--disable-silent-rules", + "--with-pythoninstall=#{lib}/gensio-python", + "--sysconfdir=#{etc}", + "--with-tclcflags=-I #{HOMEBREW_PREFIX}/include/tcl-tk" Why not the macOS one?

I didn't think about that. It won't compile on Linux without doing this, so I just used it for both. I'll fix that.

> + def python3 + "python3.11" + end Why not the latest one?

Oops, yes, that should be fixed. Thank you,

…

-corey

[cminyard]

I have made all the requested modifications, I think it's ready for another review.

[github-actions]

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

[cminyard]

Ok, one more time. Hopefully I have everything, I don't see anything else.

[cminyard]

Anything else I need to do here? It's been three weeks without any real comments.