Merge pull request #196561 from Homebrew/libxml2-drop-py311

libxml2: drop `python@3.11`, use `--with-legacy` for better ABI compat

Author: BrewTestBot

Formula/lib/libxml2.rb

@@ -14,12 +14,13 @@ class Libxml2 < Formula
   end
 
   bottle do
-    sha256 cellar: :any,                 arm64_sequoia: "958deabfc4c6a8908580a7538b1392e4a50c6f3cc7246239a62bf603ae33acaf"
-    sha256 cellar: :any,                 arm64_sonoma:  "7dd663ec7beda167b1f0705d984ccb38db2d882ef1f78678b7abecd81ddeb119"
-    sha256 cellar: :any,                 arm64_ventura: "4fe3f65d703d925efbeeff545561dabc1e3d70de359c3b2cc3e6799aa4b33e6f"
-    sha256 cellar: :any,                 sonoma:        "3bd5fd6fa2457c18f3f68e71dfc1cb0f6155a7aaa2acd93b42d3e7eb955b72d3"
-    sha256 cellar: :any,                 ventura:       "be5ba075471da4de1260ec75e78c496b3689678e8edaf5860febe9f26f4a2cd8"
-    sha256 cellar: :any_skip_relocation, x86_64_linux:  "d43aafed4f334588e937fac87b381df3c6e42f790b3828dd932512bf349b77df"
+    rebuild 1
+    sha256 cellar: :any,                 arm64_sequoia: "3211945521a13a278641145097b44c242a91afb03819efdce733dd2a39b4ca9b"
+    sha256 cellar: :any,                 arm64_sonoma:  "c7661433ff9cf455314ec3bd7fa0cc15debee3df74e6c894f82707f804471f7d"
+    sha256 cellar: :any,                 arm64_ventura: "7d218dd815b26bf68e824b45e491bbad0d4e8c5c8246d8bbe5f6de784815d788"
+    sha256 cellar: :any,                 sonoma:        "c3f316fa073279036b0c81fad21d158ddac26a30d0a457be67b753bb8fcdc2b5"
+    sha256 cellar: :any,                 ventura:       "7e48fccee11b2ee6d789460b57e1ac3b49c42297be839f05361bcfff61795b73"
+    sha256 cellar: :any_skip_relocation, x86_64_linux:  "29e6b3900187de9084702abb031c991f7918b1d44b8084bec2c52d7d37ba6a0f"
   end
 
   head do
@@ -33,7 +34,7 @@ class Libxml2 < Formula
 
   keg_only :provided_by_macos
 
-  depends_on "python@3.11" => [:build, :test]
+  depends_on "python-setuptools" => :build
   depends_on "python@3.12" => [:build, :test]
   depends_on "python@3.13" => [:build, :test]
   depends_on "pkg-config" => :test
@@ -61,6 +62,7 @@ def install
                           "--with-history",
                           "--with-http",
                           "--with-icu",
+                          "--with-legacy", # https://gitlab.gnome.org/GNOME/libxml2/-/issues/751#note_2157870
                           "--without-lzma",
                           "--without-python",
                           *std_configure_args
@@ -70,29 +72,26 @@ def install
                 .to_formula
     inreplace [bin/"xml2-config", lib/"pkgconfig/libxml-2.0.pc"], icu4c.prefix.realpath, icu4c.opt_prefix
 
-    cd "python" do
-      sdk_include = if OS.mac?
-        sdk = MacOS.sdk_path_if_needed
-        sdk/"usr/include" if sdk
-      else
-        HOMEBREW_PREFIX/"include"
-      end
+    sdk_include = if OS.mac?
+      sdk = MacOS.sdk_path_if_needed
+      sdk/"usr/include" if sdk
+    else
+      HOMEBREW_PREFIX/"include"
+    end
+
+    includes = [include, sdk_include].compact.map do |inc|
+      "'#{inc}',"
+    end.join(" ")
+
+    # We need to insert our include dir first
+    inreplace "python/setup.py", "includes_dir = [",
+                                 "includes_dir = [#{includes}"
 
-      includes = [include, sdk_include].compact.map do |inc|
-        "'#{inc}',"
-      end.join(" ")
-
-      # We need to insert our include dir first
-      inreplace "setup.py", "includes_dir = [",
-                            "includes_dir = [#{includes}"
-
-      # Needed for Python 3.12+.
-      # https://github.com/Homebrew/homebrew-core/pull/154551#issuecomment-1820102786
-      with_env(PYTHONPATH: buildpath/"python") do
-        pythons.each do |python|
-          build_isolation = Language::Python.major_minor_version(python) >= "3.12"
-          system python, "-m", "pip", "install", *std_pip_args(build_isolation:), "."
-        end
+    # Needed for Python 3.12+.
+    # https://github.com/Homebrew/homebrew-core/pull/154551#issuecomment-1820102786
+    with_env(PYTHONPATH: buildpath/"python") do
+      pythons.each do |python|
+        system python, "-m", "pip", "install", *std_pip_args, "./python"
       end
     end
   end