Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update temurin8 Cask for jdk8u422-b05.1 point release re-build #180691

Merged
merged 9 commits into from
Jul 30, 2024
Merged

Update temurin8 Cask for jdk8u422-b05.1 point release re-build #180691

merged 9 commits into from
Jul 30, 2024

Conversation

andrew-m-leonard
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard commented Jul 26, 2024 •
edited
Loading

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

@andrew-m-leonard
Copy link
Contributor Author

andrew-m-leonard commented Jul 26, 2024 •
edited
Loading

Note, I have no idea what these two checkboxes mean? I am guessing the PR template could do with a fuller explanation of what a " is the token of the cask" is?

  • brew audit --cask --online is error-free.
  • brew style --fix reports no offenses.

How does running those commands from my Mac relate to this PR?
I get:

anleonar@anleonar-mac homebrew-cask % brew audit --cask --online temurin@8
Fetching gem metadata from https://rubygems.org/.......
Fetching ast 2.4.2
Fetching parallel 1.25.1
Fetching language_server-protocol 3.17.0.3
Fetching json 2.7.2
Installing parallel 1.25.1
Installing ast 2.4.2
Fetching racc 1.8.0
Fetching rainbow 3.1.1
Installing language_server-protocol 3.17.0.3
Installing json 2.7.2 with native extensions
Installing racc 1.8.0 with native extensions
Installing rainbow 3.1.1
Fetching regexp_parser 2.9.2
Installing regexp_parser 2.9.2
Fetching ruby-progressbar 1.13.0
Fetching unicode-display_width 2.5.0
Installing ruby-progressbar 1.13.0
Installing unicode-display_width 2.5.0
Fetching parser 3.3.4.0
Installing parser 3.3.4.0
Fetching rubocop-ast 1.31.3
Installing rubocop-ast 1.31.3
Fetching rubocop 1.65.0
Installing rubocop 1.65.0
Fetching rubocop-md 1.2.2
Fetching rubocop-performance 1.21.1
Fetching rubocop-rspec 3.0.3
Fetching rubocop-sorbet 0.8.4
Installing rubocop-md 1.2.2
Installing rubocop-performance 1.21.1
Installing rubocop-rspec 3.0.3
Installing rubocop-sorbet 0.8.4
Bundle complete! 37 Gemfile dependencies, 28 gems now installed.
Bundled gems are installed into `../../../../opt/homebrew/Library/Homebrew/vendor/bundle`
Error: Cask 'temurin@8' is unavailable: No Cask with this name exists.

@andrew-m-leonard andrew-m-leonard mentioned this pull request Jul 26, 2024
Closed
8 tasks
@p-linnane p-linnane requested a review from a team July 28, 2024 16:31
@p-linnane p-linnane added the awaiting maintainer feedback Issue needs response from a maintainer. label Jul 28, 2024
khipp
khipp reviewed Jul 30, 2024
View reviewed changes
Copy link
Member

@khipp khipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, @andrew-m-leonard!

To answer your questions, the cask token refers to its identifier, temurin@8 (see documentation).

The commands brew audit --cask --online <cask> and brew style --fix <cask> allow you to fix any outstanding issues before submitting the PR. brew audit looks for a corresponding file in your installed taps (refer to our documentation on pull requests for more information).

As for the PR, I left a few suggestions below that would not require us to revert the changes on the next release.

Casks/t/[email protected] Outdated Show resolved Hide resolved
Casks/t/[email protected] Outdated Show resolved Hide resolved
Casks/t/[email protected] Outdated Show resolved Hide resolved
@andrew-m-leonard
Copy link
Contributor Author

Thank you for your contribution, @andrew-m-leonard!

To answer your questions, the cask token refers to its identifier, temurin@8 (see documentation).

The commands brew audit --cask --online <cask> and brew style --fix <cask> allow you to fix any outstanding issues before submitting the PR. brew audit looks for a corresponding file in your installed taps (refer to our documentation on pull requests for more information).

As for the PR, I left a few suggestions below that would not require us to revert the changes on the next release.

Thank you @khipp I have included your suggestions, which makes it future proof, thank you

@p-linnane p-linnane removed the awaiting maintainer feedback Issue needs response from a maintainer. label Jul 30, 2024
@p-linnane p-linnane merged commit 281d166 into Homebrew:master Jul 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-linnane p-linnane p-linnane approved these changes

@khipp khipp Awaiting requested review from khipp

Assignees
No one assigned
Labels
automerge-skip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrew-m-leonard @khipp @p-linnane @BrewTestBot