Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mblock: disable #176185

Merged
merged 1 commit into from
Jun 12, 2024
Merged

mblock: disable #176185

merged 1 commit into from
Jun 12, 2024

Conversation

khipp
Copy link
Contributor

@khipp khipp commented Jun 9, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@krehel
Copy link
Member

krehel commented Jun 12, 2024

I am not sure this Cask is viable any longer.

The download link used to get this software has a 5 second delay, and the URL to fetch the download changes per download. brew fetch does not download the DMG, but rather an HTML page.

@khipp khipp reopened this Jun 12, 2024
@khipp khipp changed the title mblock: add arm arch mblock: disable Jun 12, 2024
@khipp
Copy link
Contributor Author

khipp commented Jun 12, 2024

I went ahead and disabled the cask. Tests are still failing for the reasons stated by @krehel. Can those be skipped?

@miccal miccal added the ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. label Jun 12, 2024
@krehel
Copy link
Member

krehel commented Jun 12, 2024

Thanks @khipp!

@miccal miccal merged commit 68d2d00 into Homebrew:master Jun 12, 2024
11 of 16 checks passed
@khipp khipp deleted the update-mblock branch June 13, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-syntax-only Only run syntax checks on CI. Use only for bulk changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants