-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove OpenStruct dependency #18777
Comments
Agreed, we should do this. |
It'd be simple to create a small class that replicates the |
Yep, the class is a single file, and must of the functionality is via an It still leaves the major concerns intact though (e.g. performance & security), the code remains difficult to follow, etc. Opening this so we have a bit of time to think of something better (but feel free to self-assign if you have strong opinions). |
I see your point. The goal here is not just to remove the |
Exactly. OpenStruct is also pretty Sorbet-unfriendly. |
Verification
brew install wget
. If they do, open an issue at https://github.com/Homebrew/homebrew-core/issues/new/choose instead.Provide a detailed description of the proposed feature
ostruct
will no longer be a default gem as of Ruby 3.5: ruby/ruby#10428It's already discouraged for "performance, version compatibility, and potential security issues".
We have two instances to clean up:
Library/Homebrew/cli/args.rb
Library/Homebrew/cmd/uses.rb
What is the motivation for the feature?
☝️
How will the feature be relevant to at least 90% of Homebrew users?
resolution of the performance, version compatibility, and potential security issues described above.
What alternatives to the feature have been considered?
None
The text was updated successfully, but these errors were encountered: