Revamp installed_on_request handling #18768
Merged
+36
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
force-pushed
the
revamp_installed_on_request
branch
from
57c41bb
to
49eba46
Compare
cho-m
approved these changes
Nov 14, 2024
MikeMcQuaid
force-pushed
the
revamp_installed_on_request
branch
from
49eba46
to
319cc41
Compare
cho-m
reviewed
Nov 19, 2024
|
Otherwise LGTM. No problems with merging after above fix. |
- `reinstall` and `upgrade` no longer mark as installed on request, with or without names specified, but preserve the version from the tab instead - default `install_on_request` to `false` rather than `true` - only set installed in request in a tab if it's missing rather than false Co-authored-by: Michael Cho <[email protected]>
MikeMcQuaid
force-pushed
the
revamp_installed_on_request
branch
from
5f8d841
to
4d4531c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reinstallandupgradeno longer mark as installed on request, with or without names specified, but preserve the version from the tab insteadinstall_on_requesttofalserather thantrue@cho-m feel free to push any changes/test fixes directly to this PR as desired
Fixes #18754