-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid duplicate names/"shadowing" in homebrew/core and homebrew/cask #17560
Comments
I like this approach, though a combination with the rename is probably good. For example: the software in the Docker cask is referred to as "Docker Desktop" everywhere on the Docker website, so that's probably a better name. |
I second this. It may not make sense to rename all variations, but probably does for some, Docker being the notable example. I think keeping disambiguation is a good idea if it doesn't cause continued confusion, and does force a user decision. If there's a desire to rename conflicting items: it's probably worthwhile to have a consistent scheme, TBD if this is a route decided. Keep the formula as-is with |
The reason I don't like this approach: we will need to pick a date when we start breaking e.g.
Agreed here. I think that's an easy case to fix.
We should avoid forcing user decisions in cases like this, particularly when we have analytics. We should decide for them and, if we install the wrong thing, they can choose to uninstall and install the right one.
I don't think it makes sense universally. I know Homebrew/cask doesn't historically like Docker is a nice example, though, of where "Docker Desktop" is actually the name that upstream uses, too. |
Verification
brew install wget
. If they do, open an issue at https://github.com/Homebrew/homebrew-core/issues/new/choose instead.Provide a detailed description of the proposed feature
Doing
brew install docker
will install the Docker formula (and output a warning).brew install --cask docker
will install the Docker cask. This may make sense to Homebrew maintainers but, to many of our users, this is unnecessarily confusing. It also has resulted (and will, most likely) continue to result in many bugs over the years.We now have the ability to rename both formulae and casks. We should make use of this to pick a better name for each of the formulae and casks with overlapping names and add an audit/cop to ensure that we do not backslide and accidentally add more in future.
More often than not, this should involve renaming the cask. Casks are (generally) much less popular than the formula. If the cask has higher analytics usage (or perhaps just "higher in the rankings" than the formula, however, it may make more sense to rename the formula. Docker has half the cask installs in 365 days than formula but: it's the 4th highest installed cask and the 38th formula. Possible renames could be
docker-cli
ordocker-desktop
.Note: this will almost certainly require making changing to existing audits, documentation and name/token format.
CC @Homebrew/maintainers @Homebrew/core and @homebrew/cask for thoughts
What is the motivation for the feature?
Less confusion and fewer bugs on overlapping formulae/casks.
How will the feature be relevant to at least 90% of Homebrew users?
Removing the ability to fully understand the concept of formula and cask to just use Homebrew.
What alternatives to the feature have been considered?
The text was updated successfully, but these errors were encountered: