Use cask tab to better identify installed casks #17821
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we would identify installed casks by token derived from directories present in the caskroom directory. That was error prone when the token was ambiguous. In that case, the `Cask::Caskroom.cask` method would default to the first cask which was not always correct. Now that we have the cask tab we can use the installed receipt to get the tap a cask came from. With both the tap and the token, we can be sure that we're loading the cask that is actually installed and not another cask from a different tap that just happens to have the same name.
apainintheneck
force-pushed
the
use-cask-tab-to-better-identify-installed-casks
branch
from
4a0c72b
to
5c3a1a2
Compare
|
@apainintheneck I just opened a PR (#17823) which duplicates some of the work here. So sorry, I didn't see this until now, otherwise I would have reviewed or modified mine to work around this. My PR takes a slightly different approach (and covers an additional issue with named arguments), but I'm not sure it's a better solution, so this might still be the way to go with the |
7 tasks
|
Closing in favor of #17823 which is much more thorough and comprehensive than this PR. Any necessary discussion can happen there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?Fixes #17427
Fixes #17416
Previously we would identify installed casks by token derived from directories present in the caskroom directory. That was error prone when the token was ambiguous. In that case, the
Cask::Caskroom.caskmethod would default to the first cask which was not always correct.Now that we have the cask tab we can use the installed receipt to get the tap a cask came from. With both the tap and the token, we can be sure that we're loading the cask that is actually installed and not another cask from a different tap that just happens to have the same name.
TODO: Testing