Skip to content

Commit

Permalink
Merge pull request #16890 from Homebrew/github_actions_deprecated_dis…
Browse files Browse the repository at this point in the history
…abled_warning_error_annotations

Add GitHub Actions warning/error annotations for deprecations/disables.
  • Loading branch information
MikeMcQuaid committed Mar 14, 2024
2 parents a7d7748 + f086138 commit 92ad6a8
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
9 changes: 7 additions & 2 deletions Library/Homebrew/cask/installer.rb
Expand Up @@ -130,11 +130,16 @@ def check_deprecate_disable
deprecate_disable_type = DeprecateDisable.type(@cask)
return if deprecate_disable_type.nil?

message = DeprecateDisable.message(@cask)
message_full = "#{@cask.token} has been #{message}"

case deprecate_disable_type
when :deprecated
opoo "#{@cask.token} has been #{DeprecateDisable.message(@cask)}"
puts "::warning::#{message_full}" if ENV["GITHUB_ACTIONS"]
opoo message_full
when :disabled
raise CaskCannotBeInstalledError.new(@cask, DeprecateDisable.message(@cask))
puts "::error::#{message_full}" if ENV["GITHUB_ACTIONS"]
raise CaskCannotBeInstalledError.new(@cask, message)
end
end

Expand Down
2 changes: 2 additions & 0 deletions Library/Homebrew/extend/kernel.rb
Expand Up @@ -147,10 +147,12 @@ def odeprecated(method, replacement = nil,

disable = true if disable_for_developers && Homebrew::EnvConfig.developer?
if disable || Homebrew.raise_deprecation_exceptions?
puts "::error::#{message}" if ENV["GITHUB_ACTIONS"]
exception = MethodDeprecatedError.new(message)
exception.set_backtrace(backtrace)
raise exception
elsif !Homebrew.auditing?
puts "::warning::#{message}" if ENV["GITHUB_ACTIONS"]
opoo message
end
end
Expand Down
2 changes: 2 additions & 0 deletions Library/Homebrew/formula_installer.rb
Expand Up @@ -206,8 +206,10 @@ def prelude

case deprecate_disable_type
when :deprecated
puts "::warning::#{message}" if ENV["GITHUB_ACTIONS"]
opoo message
when :disabled
puts "::error::#{message}" if ENV["GITHUB_ACTIONS"]
raise CannotInstallFormulaError, message
end
end
Expand Down

0 comments on commit 92ad6a8

Please sign in to comment.