Skip to content

Commit 92ad6a8

Browse files
authored
Merge pull request #16890 from Homebrew/github_actions_deprecated_disabled_warning_error_annotations
Add GitHub Actions warning/error annotations for deprecations/disables.
2 parents a7d7748 + f086138 commit 92ad6a8

File tree

3 files changed

+11
-2
lines changed

3 files changed

+11
-2
lines changed

Library/Homebrew/cask/installer.rb

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,11 +130,16 @@ def check_deprecate_disable
130130
deprecate_disable_type = DeprecateDisable.type(@cask)
131131
return if deprecate_disable_type.nil?
132132

133+
message = DeprecateDisable.message(@cask)
134+
message_full = "#{@cask.token} has been #{message}"
135+
133136
case deprecate_disable_type
134137
when :deprecated
135-
opoo "#{@cask.token} has been #{DeprecateDisable.message(@cask)}"
138+
puts "::warning::#{message_full}" if ENV["GITHUB_ACTIONS"]
139+
opoo message_full
136140
when :disabled
137-
raise CaskCannotBeInstalledError.new(@cask, DeprecateDisable.message(@cask))
141+
puts "::error::#{message_full}" if ENV["GITHUB_ACTIONS"]
142+
raise CaskCannotBeInstalledError.new(@cask, message)
138143
end
139144
end
140145

Library/Homebrew/extend/kernel.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,10 +147,12 @@ def odeprecated(method, replacement = nil,
147147

148148
disable = true if disable_for_developers && Homebrew::EnvConfig.developer?
149149
if disable || Homebrew.raise_deprecation_exceptions?
150+
puts "::error::#{message}" if ENV["GITHUB_ACTIONS"]
150151
exception = MethodDeprecatedError.new(message)
151152
exception.set_backtrace(backtrace)
152153
raise exception
153154
elsif !Homebrew.auditing?
155+
puts "::warning::#{message}" if ENV["GITHUB_ACTIONS"]
154156
opoo message
155157
end
156158
end

Library/Homebrew/formula_installer.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -206,8 +206,10 @@ def prelude
206206

207207
case deprecate_disable_type
208208
when :deprecated
209+
puts "::warning::#{message}" if ENV["GITHUB_ACTIONS"]
209210
opoo message
210211
when :disabled
212+
puts "::error::#{message}" if ENV["GITHUB_ACTIONS"]
211213
raise CannotInstallFormulaError, message
212214
end
213215
end

0 commit comments

Comments
 (0)