rubocops: ignore uninstall opt-ins

Teach UninstallMethodsOrder to ignore quit_on_upgrade and
signal_on_upgrade metadata keys when checking uninstall/zap
method order, and add a spec case covering this.

Author: toobuntu

Library/Homebrew/rubocops/cask/uninstall_methods_order.rb

@@ -13,6 +13,13 @@ class UninstallMethodsOrder < Base
 
         MSG = T.let("`%<method>s` method out of order", String)
 
+        # These keys are ignored when checking method order.
+        # Mirrors AbstractUninstall::UPGRADE_METADATA_KEYS.
+        UPGRADE_METADATA_KEYS = T.let(
+          [:quit_on_upgrade, :signal_on_upgrade].freeze,
+          T::Array[Symbol],
+        )
+
         sig { params(node: AST::SendNode).void }
         def on_send(node)
           return unless [:zap, :uninstall].include?(node.method_name)
@@ -21,6 +28,12 @@ def on_send(node)
           return if hash_node.nil? || (!hash_node.is_a?(AST::Node) && !hash_node.hash_type?)
 
           method_nodes = hash_node.pairs.map(&:key)
+
+          method_nodes = method_nodes.reject do |method|
+            name = method.children.first
+            UPGRADE_METADATA_KEYS.include?(name)
+          end
+
           expected_order = method_nodes.sort_by { |method| method_order_index(method) }
           comments = processed_source.comments
 

Library/Homebrew/test/rubocops/cask/uninstall_methods_order_spec.rb

@@ -78,6 +78,28 @@
           end
         CASK
       end
+
+      it "ignores opt-in boolean keys such as quit_on_upgrade and signal_on_upgrade" do
+        expect_no_offenses(<<~CASK)
+          cask "foo" do
+            url "https://example.com/foo.zip"
+
+            uninstall quit:      "com.example.foo",
+                      quit_on_upgrade: true,
+                      signal:    ["TERM", "com.example.foo"],
+                      signal_on_upgrade: true,
+                      script:  {
+                        executable: "/usr/local/bin/foo",
+                        sudo:       false,
+                      },
+                      pkgutil: "org.foo.bar",
+                      delete:  [
+                        "/usr/local/bin/foo",
+                        "/usr/local/bin/foobar",
+                      ]
+          end
+        CASK
+      end
     end
 
     context "with a single method" do