Merge pull request #21824 from Homebrew/avoid-keg-only-versioned-autolink

Avoid auto-linking keg-only versioned formulae

Author: MikeMcQuaid

Library/Homebrew/formula_installer.rb

@@ -1729,7 +1729,10 @@ def auto_link_versioned_keg_only?
     return false unless formula.keg_only?
     return false unless formula.keg_only_reason.versioned_formula?
     return false if formula.any_version_installed?
-    return false if formula.link_overwrite_formulae.any?(&:any_version_installed?)
+    return false if formula.link_overwrite_formulae.any? do |related_formula|
+      related_formula.any_version_installed? ||
+      (related_formula.name == formula.unversioned_formula_name && related_formula.keg_only?)
+    end
 
     true
   end

Library/Homebrew/test/formula_installer_spec.rb

@@ -135,7 +135,8 @@ def temporary_install(formula, **options)
     end
 
     before do
-      allow(keg_only_formula).to receive_messages(any_version_installed?: false, link_overwrite_formulae: [])
+      allow(keg_only_formula).to receive_messages(any_version_installed?:  false,
+                                                  link_overwrite_formulae: [])
     end
 
     it "links by default when no sibling variants are installed" do
@@ -185,6 +186,18 @@ def temporary_install(formula, **options)
       expect(fi.link_keg).to be false
     end
 
+    it "does not link by default when the unversioned sibling is keg-only" do
+      unversioned_formula = formula base_name do
+        url "foo-1.0"
+        keg_only "some reason"
+      end
+      allow(keg_only_formula).to receive(:link_overwrite_formulae).and_return([unversioned_formula])
+
+      fi = described_class.new(keg_only_formula)
+
+      expect(fi.link_keg).to be false
+    end
+
     it "does not link by default when the -full variant is installed" do
       full_variant = formula "#{base_name}-full" do
         url "foo-full-1.0"