Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add copy command keybind #1126

Closed
wants to merge 1 commit into from
Closed

Conversation

xplo1t-sec
Copy link

Users can now press C on their keyboard to copy the brew install command.

@xplo1t-sec
Copy link
Author

We can also add some text to let people know that they can use the C button keybind. Let me know if you have any idea to do this.

@bevanjkay
Copy link
Member

Thank you for your contribution @xplo1t-sec - but I don't think this change is suitable here.

I'm not a fan of intercepting keypresses on a static website as it is not the expected user experience.
The current implementation will also run the function even if the user is trying to copy something else on the page (using the standard shortcut cmd + c).

@xplo1t-sec
Copy link
Author

Your point is valid

@p-linnane
Copy link
Member

Closing per above.

@p-linnane p-linnane closed this Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants