Skip to content

Commit cf32d20

Browse files
hf-kkleinKonstantin
andauthored
chore: bump ahbicht min-version (reduces number of invalid expressions) (#128)
the ahbicht version is unpinned so this might lead to CI failures even though no code was changed (if ahbicht released a new version) Co-authored-by: Konstantin <[email protected]>
1 parent 4e599ce commit cf32d20

File tree

2 files changed

+3
-140
lines changed

2 files changed

+3
-140
lines changed

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ sqlmodels = [
2929
"sqlalchemy[mypy]>=2.0.37"
3030
]
3131
ahbicht = [
32-
"ahbicht>=0.13.2"
32+
"ahbicht>=0.14.0"
3333
]
3434
coverage = [
3535
"coverage==7.8.0"

unittests/__snapshots__/test_sqlmodels_expressions_view.ambr

Lines changed: 2 additions & 139 deletions
Original file line numberDiff line numberDiff line change
@@ -596,30 +596,12 @@
596596
# ---
597597
# name: test_create_expressions_table_from_submodule_with_validity
598598
list([
599-
dict({
600-
'ahbicht_error_message': '''
601-
ahb expression: X ([950] [509] ∧ ([64] V [70])) V ([960] [522] ∧ [71] ∧ [53]) Please make sure that the ahb_expression starts with a requirement indicator (i.e Muss/M, Soll/S, Kann/K, X, O, U) and the condition expressions consist of only the following characters: [ ] ( ) U ∧ O ∨ X ⊻ and digits.
602-
condition expression: X ([950] [509] ∧ ([64] V [70])) V ([960] [522] ∧ [71] ∧ [53])
603-
Please make sure that:
604-
* all conditions have the form [INT]
605-
* all packages have the form [INTPn..m]
606-
* no conditions are empty
607-
* all compositions are combined by operators 'U'/'O'/'X' or without an operator
608-
* all open brackets are closed again and vice versa
609-
610-
''',
611-
'edifact_format_version': 'FV2410',
612-
'expression': 'X ([950] [509] ∧ ([64] V [70])) V ([960] [522] ∧ [71] ∧ [53])',
613-
'format': 'INVOIC',
614-
'node_texts': '',
615-
}),
616599
dict({
617600
'ahbicht_error_message': '''
618601
Error trying to process rule "CONDITION_EXPRESSION":
619602

620603

621-
condition expression: ([446] ∧ ([465] ∨ [466]) ∧ [467] ∧ ([468] ⊻ ([469] ∧ [470])) ⊻ [448]
622-
604+
condition expression: ([446] ∧ ([465] ∨ [466]) ∧ [467] ∧ ([468] ⊻ ([469] ∧ [470])) ⊻ [448]
623605
Please make sure that:
624606
* all conditions have the form [INT]
625607
* all packages have the form [INTPn..m]
@@ -636,29 +618,12 @@
636618
'format': 'UTILMD',
637619
'node_texts': '',
638620
}),
639-
dict({
640-
'ahbicht_error_message': '''
641-
ahb expression: X ([950] [509] ∧ ([64] V [70])) V ([960] [522] ∧ [71] ∧ [53]) Please make sure that the ahb_expression starts with a requirement indicator (i.e Muss/M, Soll/S, Kann/K, X, O, U) and the condition expressions consist of only the following characters: [ ] ( ) U ∧ O ∨ X ⊻ and digits.
642-
condition expression: X ([950] [509] ∧ ([64] V [70])) V ([960] [522] ∧ [71] ∧ [53])
643-
Please make sure that:
644-
* all conditions have the form [INT]
645-
* all packages have the form [INTPn..m]
646-
* no conditions are empty
647-
* all compositions are combined by operators 'U'/'O'/'X' or without an operator
648-
* all open brackets are closed again and vice versa
649-
650-
''',
651-
'edifact_format_version': 'FV2504',
652-
'expression': 'X ([950] [509] ∧ ([64] V [70])) V ([960] [522] ∧ [71] ∧ [53])',
653-
'format': 'INVOIC',
654-
'node_texts': '',
655-
}),
656621
dict({
657622
'ahbicht_error_message': '''
658623
Error trying to process rule "CONDITION_EXPRESSION":
659624

660625

661-
condition expression: ([62] ∧ [108]) ⊻ ([148] ∨ ([149] ∧ [150])
626+
condition expression: ([62] ∧ [108]) ⊻ ([148] ∨ ([149] ∧ [150])
662627
Please make sure that:
663628
* all conditions have the form [INT]
664629
* all packages have the form [INTPn..m]
@@ -672,107 +637,5 @@
672637
'format': 'UTILMD',
673638
'node_texts': '',
674639
}),
675-
dict({
676-
'ahbicht_error_message': '''
677-
ahb expression: X [1P0..n] Please make sure that the ahb_expression starts with a requirement indicator (i.e Muss/M, Soll/S, Kann/K, X, O, U) and the condition expressions consist of only the following characters: [ ] ( ) U ∧ O ∨ X ⊻ and digits.
678-
condition expression: X [1P0..n]
679-
Please make sure that:
680-
* all conditions have the form [INT]
681-
* all packages have the form [INTPn..m]
682-
* no conditions are empty
683-
* all compositions are combined by operators 'U'/'O'/'X' or without an operator
684-
* all open brackets are closed again and vice versa
685-
686-
''',
687-
'edifact_format_version': 'FV2504',
688-
'expression': 'X [1P0..n]',
689-
'format': 'UTILMD',
690-
'node_texts': '',
691-
}),
692-
dict({
693-
'ahbicht_error_message': '''
694-
ahb expression: X [1P1..n] Please make sure that the ahb_expression starts with a requirement indicator (i.e Muss/M, Soll/S, Kann/K, X, O, U) and the condition expressions consist of only the following characters: [ ] ( ) U ∧ O ∨ X ⊻ and digits.
695-
condition expression: X [1P1..n]
696-
Please make sure that:
697-
* all conditions have the form [INT]
698-
* all packages have the form [INTPn..m]
699-
* no conditions are empty
700-
* all compositions are combined by operators 'U'/'O'/'X' or without an operator
701-
* all open brackets are closed again and vice versa
702-
703-
''',
704-
'edifact_format_version': 'FV2504',
705-
'expression': 'X [1P1..n]',
706-
'format': 'UTILMD',
707-
'node_texts': '',
708-
}),
709-
dict({
710-
'ahbicht_error_message': '''
711-
ahb expression: X [2P0..n] Please make sure that the ahb_expression starts with a requirement indicator (i.e Muss/M, Soll/S, Kann/K, X, O, U) and the condition expressions consist of only the following characters: [ ] ( ) U ∧ O ∨ X ⊻ and digits.
712-
condition expression: X [2P0..n]
713-
Please make sure that:
714-
* all conditions have the form [INT]
715-
* all packages have the form [INTPn..m]
716-
* no conditions are empty
717-
* all compositions are combined by operators 'U'/'O'/'X' or without an operator
718-
* all open brackets are closed again and vice versa
719-
720-
''',
721-
'edifact_format_version': 'FV2504',
722-
'expression': 'X [2P0..n]',
723-
'format': 'UTILMD',
724-
'node_texts': '',
725-
}),
726-
dict({
727-
'ahbicht_error_message': '''
728-
ahb expression: X [3P0..n] Please make sure that the ahb_expression starts with a requirement indicator (i.e Muss/M, Soll/S, Kann/K, X, O, U) and the condition expressions consist of only the following characters: [ ] ( ) U ∧ O ∨ X ⊻ and digits.
729-
condition expression: X [3P0..n]
730-
Please make sure that:
731-
* all conditions have the form [INT]
732-
* all packages have the form [INTPn..m]
733-
* no conditions are empty
734-
* all compositions are combined by operators 'U'/'O'/'X' or without an operator
735-
* all open brackets are closed again and vice versa
736-
737-
''',
738-
'edifact_format_version': 'FV2504',
739-
'expression': 'X [3P0..n]',
740-
'format': 'UTILMD',
741-
'node_texts': '',
742-
}),
743-
dict({
744-
'ahbicht_error_message': '''
745-
ahb expression: X [4P0..n] Please make sure that the ahb_expression starts with a requirement indicator (i.e Muss/M, Soll/S, Kann/K, X, O, U) and the condition expressions consist of only the following characters: [ ] ( ) U ∧ O ∨ X ⊻ and digits.
746-
condition expression: X [4P0..n]
747-
Please make sure that:
748-
* all conditions have the form [INT]
749-
* all packages have the form [INTPn..m]
750-
* no conditions are empty
751-
* all compositions are combined by operators 'U'/'O'/'X' or without an operator
752-
* all open brackets are closed again and vice versa
753-
754-
''',
755-
'edifact_format_version': 'FV2504',
756-
'expression': 'X [4P0..n]',
757-
'format': 'UTILMD',
758-
'node_texts': '',
759-
}),
760-
dict({
761-
'ahbicht_error_message': '''
762-
ahb expression: X [5P0..n] Please make sure that the ahb_expression starts with a requirement indicator (i.e Muss/M, Soll/S, Kann/K, X, O, U) and the condition expressions consist of only the following characters: [ ] ( ) U ∧ O ∨ X ⊻ and digits.
763-
condition expression: X [5P0..n]
764-
Please make sure that:
765-
* all conditions have the form [INT]
766-
* all packages have the form [INTPn..m]
767-
* no conditions are empty
768-
* all compositions are combined by operators 'U'/'O'/'X' or without an operator
769-
* all open brackets are closed again and vice versa
770-
771-
''',
772-
'edifact_format_version': 'FV2504',
773-
'expression': 'X [5P0..n]',
774-
'format': 'UTILMD',
775-
'node_texts': '',
776-
}),
777640
])
778641
# ---

0 commit comments

Comments
 (0)