diff --git a/hipparchus-core/src/main/java/org/hipparchus/analysis/integration/gauss/AbstractRuleFactory.java b/hipparchus-core/src/main/java/org/hipparchus/analysis/integration/gauss/AbstractRuleFactory.java index fda47cac1..99458dfee 100644 --- a/hipparchus-core/src/main/java/org/hipparchus/analysis/integration/gauss/AbstractRuleFactory.java +++ b/hipparchus-core/src/main/java/org/hipparchus/analysis/integration/gauss/AbstractRuleFactory.java @@ -130,8 +130,8 @@ protected double[] findRoots(final int n, final UnivariateFunction ratioEvaluato // use Aberth method to find all roots simultaneously final double[] ratio = new double[n]; final Incrementor incrementor = new Incrementor(1000); - double tol = Double.NaN; - double maxOffset = Double.NaN; + double tol; + double maxOffset; do { // safety check that triggers an exception if too much iterations are made diff --git a/hipparchus-core/src/main/java/org/hipparchus/analysis/integration/gauss/FieldAbstractRuleFactory.java b/hipparchus-core/src/main/java/org/hipparchus/analysis/integration/gauss/FieldAbstractRuleFactory.java index 28db19100..7e2bd9269 100644 --- a/hipparchus-core/src/main/java/org/hipparchus/analysis/integration/gauss/FieldAbstractRuleFactory.java +++ b/hipparchus-core/src/main/java/org/hipparchus/analysis/integration/gauss/FieldAbstractRuleFactory.java @@ -153,8 +153,8 @@ protected T[] findRoots(final int n, final CalculusFieldUnivariateFunction ra // use Aberth method to find all roots simultaneously final T[] ratio = MathArrays.buildArray(field, n); final Incrementor incrementor = new Incrementor(1000); - double tol = Double.NaN; - double maxOffset = Double.NaN; + double tol; + double maxOffset; do { // safety check that triggers an exception if too much iterations are made diff --git a/hipparchus-core/src/main/java/org/hipparchus/dfp/Dfp.java b/hipparchus-core/src/main/java/org/hipparchus/dfp/Dfp.java index 3ba501ed3..2411621a1 100644 --- a/hipparchus-core/src/main/java/org/hipparchus/dfp/Dfp.java +++ b/hipparchus-core/src/main/java/org/hipparchus/dfp/Dfp.java @@ -268,7 +268,6 @@ protected Dfp(final DfpField field, long x) { protected Dfp(final DfpField field, double x) { // initialize as if 0 - sign = 1; mant = new int[field.getRadixDigits()]; this.field = field; @@ -282,6 +281,8 @@ protected Dfp(final DfpField field, double x) { // make sure 0 has the right sign if ((bits & 0x8000000000000000L) != 0) { sign = -1; + } else { + sign = 1; } return; } diff --git a/hipparchus-core/src/main/java/org/hipparchus/util/BigReal.java b/hipparchus-core/src/main/java/org/hipparchus/util/BigReal.java index 2298003b9..b1c5d56d6 100644 --- a/hipparchus-core/src/main/java/org/hipparchus/util/BigReal.java +++ b/hipparchus-core/src/main/java/org/hipparchus/util/BigReal.java @@ -135,16 +135,16 @@ public BigReal(char[] in, MathContext mc) { /** Build an instance from a double. * @param val value of the instance */ - public BigReal(double val) { // NOPMD - we really want double conversion here - d = new BigDecimal(val); + public BigReal(double val) { + d = new BigDecimal(val); // NOPMD - we really want double conversion here } /** Build an instance from a double. * @param val value of the instance * @param mc context to use */ - public BigReal(double val, MathContext mc) { // NOPMD - we really want double conversion here - d = new BigDecimal(val, mc); + public BigReal(double val, MathContext mc) { + d = new BigDecimal(val, mc); // NOPMD - we really want double conversion here } /** Build an instance from an int.