Fixed PMD warnings.

Hipparchus-Math · Jul 30, 2021 · c67c5bf · c67c5bf
1 parent 7c3e638
commit c67c5bf
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 9 deletions.
diff --git a/...hus-core/src/main/java/org/hipparchus/analysis/integration/gauss/AbstractRuleFactory.java b/...hus-core/src/main/java/org/hipparchus/analysis/integration/gauss/AbstractRuleFactory.java
@@ -130,8 +130,8 @@ protected double[] findRoots(final int n, final UnivariateFunction ratioEvaluato
         // use Aberth method to find all roots simultaneously
         final double[]    ratio       = new double[n];
         final Incrementor incrementor = new Incrementor(1000);
-        double            tol         = Double.NaN;
-        double            maxOffset   = Double.NaN;
+        double            tol;
+        double            maxOffset;
         do {
 
             // safety check that triggers an exception if too much iterations are made

diff --git a/...ore/src/main/java/org/hipparchus/analysis/integration/gauss/FieldAbstractRuleFactory.java b/...ore/src/main/java/org/hipparchus/analysis/integration/gauss/FieldAbstractRuleFactory.java
@@ -153,8 +153,8 @@ protected T[] findRoots(final int n, final CalculusFieldUnivariateFunction<T> ra
         // use Aberth method to find all roots simultaneously
         final T[]         ratio       = MathArrays.buildArray(field, n);
         final Incrementor incrementor = new Incrementor(1000);
-        double            tol         = Double.NaN;
-        double            maxOffset   = Double.NaN;
+        double            tol;
+        double            maxOffset;
         do {
 
             // safety check that triggers an exception if too much iterations are made

diff --git a/hipparchus-core/src/main/java/org/hipparchus/dfp/Dfp.java b/hipparchus-core/src/main/java/org/hipparchus/dfp/Dfp.java
@@ -268,7 +268,6 @@ protected Dfp(final DfpField field, long x) {
     protected Dfp(final DfpField field, double x) {
 
         // initialize as if 0
-        sign = 1;
         mant = new int[field.getRadixDigits()];
         this.field = field;
 
@@ -282,6 +281,8 @@ protected Dfp(final DfpField field, double x) {
                 // make sure 0 has the right sign
                 if ((bits & 0x8000000000000000L) != 0) {
                     sign = -1;
+                } else {
+                    sign = 1;
                 }
                 return;
             }

diff --git a/hipparchus-core/src/main/java/org/hipparchus/util/BigReal.java b/hipparchus-core/src/main/java/org/hipparchus/util/BigReal.java
@@ -135,16 +135,16 @@ public BigReal(char[] in, MathContext mc) {
     /** Build an instance from a double.
      * @param val value of the instance
      */
-    public BigReal(double val) { // NOPMD - we really want double conversion here
-        d = new BigDecimal(val);
+    public BigReal(double val) {
+        d = new BigDecimal(val); // NOPMD - we really want double conversion here
     }
 
     /** Build an instance from a double.
      * @param val value of the instance
      * @param mc context to use
      */
-    public BigReal(double val, MathContext mc) { // NOPMD - we really want double conversion here
-        d = new BigDecimal(val, mc);
+    public BigReal(double val, MathContext mc) {
+        d = new BigDecimal(val, mc); // NOPMD - we really want double conversion here
     }
 
     /** Build an instance from an int.