You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
get_sentence_ngrams, get_neighbor_sentence_ngrams, same_sentence are placed under fonduer.utils.data_model_utils.tabular module, but their names sound and their behaviours look textual.
To Reproduce
Steps to reproduce the behavior:
Go to '...'
Click on '....'
Execute the code '...'
If necessary, attach example data which can be used to replicate the issue.
Expected behavior
Move them into fonduer.utils.data_model_utils.textual?
Error Logs/Screenshots
If applicable, add error logs or screenshots to help explain your problem.
Environment (please complete the following information)
Fonduer Version: 0.8.2
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered:
HiromuHota
pushed a commit
to HiromuHota/fonduer
that referenced
this issue
Sep 9, 2020
Description of the bug
get_sentence_ngrams
,get_neighbor_sentence_ngrams
,same_sentence
are placed underfonduer.utils.data_model_utils.tabular
module, but their names sound and their behaviours look textual.To Reproduce
Steps to reproduce the behavior:
If necessary, attach example data which can be used to replicate the issue.
Expected behavior
Move them into
fonduer.utils.data_model_utils.textual
?Error Logs/Screenshots
If applicable, add error logs or screenshots to help explain your problem.
Environment (please complete the following information)
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: