Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readthedocs issue with Emmental #366

Open
senwu opened this issue Nov 18, 2019 · 3 comments
Open

Readthedocs issue with Emmental #366

senwu opened this issue Nov 18, 2019 · 3 comments
Labels
bug Something isn't working docs Related to our documentation

Comments

@senwu
Copy link
Collaborator

senwu commented Nov 18, 2019 •
edited by lukehsiao
Loading

Describe the bug
Fix the readthedocs issue with Emmental

To Reproduce
There are some sphinx.ext.autodoc.importer._MockObject in the current readthedoc.

Expected behavior
Have the correct inheritance information.

See #329 for context on this bug.
@lukehsiao lukehsiao added bug Something isn't working docs Related to our documentation labels Nov 18, 2019
@lukehsiao lukehsiao added this to the v0.8.0 milestone Nov 18, 2019
@lukehsiao
Copy link
Contributor

This was just merged: readthedocs/sphinx-autoapi#183.

So, we may be able to do some workaround now.

@lukehsiao lukehsiao removed this from the v0.8.0 milestone Apr 7, 2020
@HiromuHota
Copy link
Contributor

I've just acknowledged this issue myself.
This issue snorkel-team/snorkel#1274 may be relevant?

mocks and type hints don't work together very well (agronholm/sphinx-autodoc-typehints#70)

@HiromuHota
Copy link
Contributor

Is this still an issue?
I can't find any _MockObject in the readthedocs. (see the search result at https://readthedocs.org/projects/fonduer/search/?q=_MockObject)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working docs Related to our documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@senwu @lukehsiao @HiromuHota