Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directory Tree Generator #1377

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Directory Tree Generator #1377

wants to merge 4 commits into from

Conversation

kaustav202
Copy link

Description

Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.

Added Directory Tree Generator CLI App

Fixes #1308

Replace issue_no with the issue number which is fixed in this PR

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests/screenshots(if any) that prove my fix is effective or that my feature works

@ghost
Copy link

ghost commented Apr 20, 2022 •
edited by ghost

CodeSee Review Map:

Review these changes using an interactive CodeSee Map

Review in an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

ClasherKasten
ClasherKasten reviewed Oct 3, 2022
View reviewed changes
Copy link
Collaborator

@ClasherKasten ClasherKasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good to me. Please just consider to adjust the looking a bit through changing the pipe to the unicode character.

Python/Directory-Tree-Generator/dstree/dstree.py
import os
import pathlib

PIPE = "|"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a unicode character which would be better suitable instead of a simple |, namely U+2502

Python/Directory-Tree-Generator/dstree/dstree.py
PIPE = "|"
ELBOW = "└──"
TEE = "├──"
PIPE_PREFIX = "| "
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClasherKasten ClasherKasten ClasherKasten left review comments

@HarshCasper HarshCasper Awaiting requested review from HarshCasper

@iamakkkhil iamakkkhil Awaiting requested review from iamakkkhil

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[script request]: Python Directory Tree Generator
3 participants
@kaustav202 @ClasherKasten @HarshCasper