Fix parsers (#3)

* test space

* test space

* removed space

* removed space

* Added setSourceUrl to Media Model,
Added first version MediaParser

* Added first version test case for RewriteMediaUrl, installed phpunit

* changes to mediaurl test

* changes to mediaurl test

* unsure if we want this test

* unsure if we want this test

* Added check if file exists, use the existing one

* composer.lock revert

* rewrote test for RewriteMediaUrl

* pr changes

* pr changes

Author: GeorgosXL

Model/Media.php

@@ -26,7 +26,7 @@ class Media
      */
     private $sourceUrl;
 
-    public function __construct(array $data)
+    public function __construct(array $data = [])
     {
         if (empty($data)) {
             return;
@@ -57,4 +57,9 @@ public function getSourceUrl(): string
     {
         return $this->sourceUrl;
     }
+
+    public function setSourceUrl(string $sourceUrl)
+    {
+        $this->sourceUrl = $sourceUrl;
+    }
 }

Parser/RewriteMediaUrl.php

@@ -0,0 +1,43 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Happyr\WordpressBundle\Parser;
+
+use Happyr\WordpressBundle\Model\Media;
+use Happyr\WordpressBundle\Service\ImageUploaderInterface;
+
+class RewriteMediaUrl implements MediaParserInterface
+{
+    private $remoteUrl;
+    private $imageUploader;
+
+    public function __construct(string $remoteUrl, ImageUploaderInterface $imageUploader)
+    {
+        $this->remoteUrl = $remoteUrl;
+        $this->imageUploader = $imageUploader;
+    }
+
+    public function parseMedia(Media $media): void
+    {
+        $media->setSourceUrl($this->rewriteUrl($media->getSourceUrl()));
+    }
+
+    private function rewriteUrl(string $content): string
+    {
+        $remoteUrl = parse_url($this->remoteUrl);
+        $contentUrl = parse_url($content);
+
+        if (!$contentUrl) {
+            return $content;
+        }
+
+        if (!empty($contentUrl['host']) && $remoteUrl['host'] === $contentUrl['host']) {
+
+            // rewrite the URL.
+            $content = $this->imageUploader->uploadImage($content);
+        }
+
+        return $content;
+    }
+}

Service/LocalImageUploader.php

@@ -37,8 +37,13 @@ public function uploadImage(string $url): string
 
         $filename = \basename($url);
 
-        // Save the file
-        \file_put_contents(\sprintf('%s/%s', $this->uploadsFolder, $filename), $file);
+        $path = \sprintf('%s/%s', $this->uploadsFolder, $filename);
+
+        // Check if file already exists
+        if (!\file_exists($path)) {
+            // Save the file
+            \file_put_contents($path, $file);
+        }
 
         return \sprintf('%s/%s', $this->webPrefix, $filename);
     }

Tests/Parser/RewriteMediaUrlTest.php

@@ -0,0 +1,41 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Happyr\WordpressBundle\Tests\Parser;
+
+use Happyr\WordpressBundle\Model\Media;
+use Happyr\WordpressBundle\Parser\RewriteMediaUrl;
+use Happyr\WordpressBundle\Service\ImageUploaderInterface;
+use PHPUnit\Framework\TestCase;
+
+class RewriteMediaUrlTest extends TestCase
+{
+    /**
+     * @dataProvider urlProvider
+     */
+    public function testRewrite($inputUrl, $outputUrl)
+    {
+        $media = new Media();
+        $media->setSourceUrl($inputUrl);
+        $imageUploader = $this->getMockBuilder(ImageUploaderInterface::class)
+            ->setMethods(['uploadImage'])
+            ->getMock();
+
+        $imageUploader->method('uploadImage')->willReturn($outputUrl);
+
+        $parser = new RewriteMediaUrl($inputUrl, $imageUploader);
+        $parser->parseMedia($media);
+
+        $this->assertEquals($outputUrl, $media->getSourceUrl());
+    }
+
+    public function urlProvider()
+    {
+        $inputUrl = 'http://wordpress.com/wp-conent/uploads/2018/foobar.jpg';
+        $malformedUrl = 'htp:/wordpress.com/wp-conent/uploads/2018/foobar.jpg';
+
+        yield [$inputUrl, 'https://www.happyr.com/images/foobar.jpg'];
+        yield [$malformedUrl, $malformedUrl];
+    }
+}

composer.json

@@ -14,6 +14,7 @@
         "twig/twig": "^2.0"
     },
     "require-dev": {
+        "phpunit/phpunit": "^7.4",
         "symfony/phpunit-bridge": "^4.1"
     },
     "config": {

phpunit.xml.dist

@@ -8,16 +8,13 @@
          convertWarningsToExceptions="true"
          processIsolation="false"
          stopOnFailure="false"
-         syntaxCheck="false"
-         codecoverage="true"
          bootstrap="./vendor/autoload.php"
         >
 
     <php>
         <env name="ENV" value="test" />
     </php>
 
-    <formatter type="clover" usefile="false"/>
     <testsuites>
         <testsuite name="Test Suite">
             <directory>./Tests</directory>