The window_filter event handler might receive an invalid pid #3814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes an app generates an event just before dying/terminating thus the event handler tries to retrieve the app of the PID but it is no longer available. This patch avoids a crash due to not finding the app for the given pid
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3814 +/- ##
==========================================
- Coverage 27.41% 27.34% -0.07%
==========================================
Files 188 188
Lines 51445 51445
==========================================
- Hits 14103 14069 -34
- Misses 37342 37376 +34 🚀 New features to boost your workflow:
|
dmgerman
changed the title
Member
|
Thanks! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes an app generates an event just before dying/terminating
thus the window_filter event handler tries to retrieve the app of the PID but it is no longer available. This patch avoids a crash due to not finding the app for the given pid