Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to calibration routine #1778

Open
gustafsonsven opened this issue Jan 22, 2025 · 0 comments
Open

Updates to calibration routine #1778

gustafsonsven opened this issue Jan 22, 2025 · 0 comments

Comments

@gustafsonsven
Copy link

Hi all,

As promised during yesterday's meeting here are the comments/suggestions Kate and I put together after going through HEDM calibration on the dexela dualpanel setup. To be clear, the changes that have been made so far are already phenomenal.

General:

  • When working with sub-panels, each individual sub-panel is listed directly under the Detector key while the actual detector it is on is noted as a group key within the sub-panel. I can envision confusion arising from this and suggest that we invert the tree such that, say, for the Dexelas the tree looks like: Detectors -> FF1 -> FF1_0_0. This would be a change to the general layout of the instrument class as I understand it. Perhaps we should investigate an Instrument class, a Detector class, and a Sup-panel class for easier instrument comprehension?
  • The instrument can be a little confusing to view in the GUI. As a suggestion perhaps the whole instrument view can be changed with a drop down that is either "Instrument", "Detector", "Sub-panel" level (and only each of those if they exist). The "Instrument" would lock all Detectors together such that you see one set of tilts and translations. The "Detector", in the case of the dexelas, would show two Detectors, each with a set of tilts and translations. The "Sub-panel" would show each sub-panel, with its tilts and translations. This would provide easier manual control of the detectors for coarse movements such that I could translate the whole detector without going to the slider view and moving a sub-panel where the greater detector's position is difficult to interpret.

Powder Calibration:

  • When reading in powder data, it often has not be "pre-processed" so the flips have not been applied to the raw images. When loading them in, we have to tell each individual sub-panel the flip - can we have the ability to push the flip to all sub-panels on a detector?
  • I think this would fall out naturally from implementation of the above, but we will need to lock and calibrate at all of the previously listed scales: "Instrument", "Detector", "Sub-panel".

Single crystal Calibration:

  • Similar to above, the ability to calibrate each "Instrument", "Detector", "Sub-panel".
  • Can the re-fit be checked as the default. There are good reasons to be able to uncheck it - but generally, users should find that the re-fit is helpful.
  • The deltas that are provided as bounds in the powder calibration are amazing and would be very helpful in this calibration as well.

Feel free to reach out with any questions or bring up these discussion points at our next meeting.

Thanks,
Sven

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant