Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ConfigParser instead of deprecated SafeConfigParser #771

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ZackAttack614
Copy link
Collaborator

Resolves issue #769. SafeConfigParser is removed in Python 3.12.

See source code here: https://github.com/python/cpython/blob/v3.11.1/Lib/configparser.py#L1242-L1252

Allow testing of each OS Github Action workflow individually, temporarily.
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.12%. Comparing base (759a303) to head (54dd5b5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #771   +/-   ##
=======================================
  Coverage   46.12%   46.12%           
=======================================
  Files         142      142           
  Lines       22822    22822           
=======================================
  Hits        10526    10526           
  Misses      12296    12296           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZackAttack614
Copy link
Collaborator Author

The change to ConfigParser somehow negatively affects MacOS, but the tests pass in Linux and Windows. I'm not sure why this would be, will look into it. It's a bit cumbersome since I don't have access to a Mac.

@psavery
Copy link
Collaborator

psavery commented Feb 25, 2025

The error here was just caused by a new version of PyCIFRW, and is fixed in #772

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants