Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasets with datatype float16 cannot be displayed in HDFView #138

Closed
nikolasborrel opened this issue Jun 26, 2023 · 16 comments
Closed

Datasets with datatype float16 cannot be displayed in HDFView #138

nikolasborrel opened this issue Jun 26, 2023 · 16 comments
Assignees
Labels
Priority - 2. Medium ⏹ It would be nice to have this in the next release Type - Bug Please report security issues to [email protected] instead of creating an issue on GitHub

Comments

@nikolasborrel
Copy link

When writing datasets with datatype float16, HDFView 3.3.0 returns the error "data value is null."

Is there a solution for this?

Screenshot 2023-06-26 at 13 24 44

@nikolasborrel
Copy link
Author

I'm using HDFView on MacOS, in case.

@byrnHDF
Copy link
Collaborator

byrnHDF commented Jun 26, 2023

There should be a way to display a custom float datatype, we will need a testfile at the least. A "C" generate file program would be helpful.
Does h5dump display this correctly?

@mattjala mattjala added Type - Bug Please report security issues to [email protected] instead of creating an issue on GitHub Priority - 2. Medium ⏹ It would be nice to have this in the next release labels Jul 3, 2023
@sanssecours
Copy link

I think I have the same problem. As fars as I can tell the datatype does not matter. I uploaded an example file: 1695739243.hdf5.zip

Here is a screenshot of the data set acceleration of the example file in HDFView 3.2.0:

HDFView 3 2 0

The same data in HDFView 3.3.1:

HDFView 3 3 1

Does h5dump display this correctly?

Yep. The command:

h5dump -d acceleration measurement/1695739243.hdf5 | head -n 50

prints the following output on my machine:

HDF5 "measurement/1695739243.hdf5" {
DATASET "acceleration" {
   DATATYPE  H5T_COMPOUND {
      H5T_STD_U8LE "counter";
      H5T_STD_U64LE "timestamp";
      H5T_IEEE_F32LE "x";
   }
   DATASPACE  SIMPLE { ( 14736 ) / ( H5S_UNLIMITED ) }
   DATA {
   (0): {
         1,
         0,
         -0.587472
      },
   (1): {
         1,
         0,
         -0.563058
      },
   (2): {
         1,
         0,
         -0.572213
      },
   (3): {
         2,
         179,
         -0.529488
      },
   (4): {
         2,
         179,
         -0.560006
      },
   (5): {
         2,
         179,
         -0.596628
      },
   (6): {
         3,
         364,
         -0.541695
      },
   (7): {
         3,
         364,
         -0.53254
      },
   (8): {

@byrnHDF
Copy link
Collaborator

byrnHDF commented Sep 26, 2023

A simple compound should display! I will double-check but I don't see a reason right now. I will try that file, too. Are these problems on a mac only?

@byrnHDF
Copy link
Collaborator

byrnHDF commented Sep 26, 2023

I think this must be a mac specific issue. linux is fine.

@byrnHDF
Copy link
Collaborator

byrnHDF commented Sep 26, 2023

I would like to request more info on system, os version in particular.

@sanssecours
Copy link

I would like to request more info on system, os version in particular.

I use macOS, just like the original author of the issue.

I think this must be a mac specific issue. linux is fine.

That might be correct.

@byrnHDF
Copy link
Collaborator

byrnHDF commented Sep 26, 2023

Do you have a version number for the MacOS?

@sanssecours
Copy link

Do you have a version number for the MacOS?

macOS 13.6 (22G120)

@byrnHDF
Copy link
Collaborator

byrnHDF commented Sep 26, 2023

Thanks

@byrnHDF
Copy link
Collaborator

byrnHDF commented Sep 26, 2023

I also found that file failed on windows. Then I noticed that the dataset is compressed! And trying a non-compressed file of compounds works.
tcompound_complex2.zip

@byrnHDF
Copy link
Collaborator

byrnHDF commented Sep 26, 2023

AHHHH! The first build of 3.3.1on Sep 5 used incomplete HDF5 binaries (without compression). We released new 1.14.2 binaries and rebuilt HDFView on Sep 22. Please redownload the newer HDFView.

@sanssecours
Copy link

Looks like both the “Installer” and the “Application Image” for macOS from the offical download page are still outdated. Both versions show *ERROR* fields instead of the stored data. As far as I can tell from the modification/creation dates, the “Installer“ application was built on the 23th of August while the “Application Image” app was built a day later (24th of August).

For anyone else searching for the updated and working binaries, they are available here.

@byrnHDF
Copy link
Collaborator

byrnHDF commented Sep 26, 2023

Looks like we dropped the ball on updating the download site. The files should be there tomorrow (should happen soon)

@theGidy
Copy link

theGidy commented Oct 26, 2023

Please update your download links for windows on https://www.hdfgroup.org/downloads/hdfview/ as well, i had to use this link https://support.hdfgroup.org/ftp/HDF5/releases/HDF-JAVA/hdfview-3.3.1/bin/ to recive the new correct version.

@byrnHDF
Copy link
Collaborator

byrnHDF commented May 30, 2024

Releases from now on are available from github

@byrnHDF byrnHDF closed this as completed May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority - 2. Medium ⏹ It would be nice to have this in the next release Type - Bug Please report security issues to [email protected] instead of creating an issue on GitHub
Projects
None yet
Development

No branches or pull requests

5 participants