Skip to content

Commit bb73af2

Browse files
authored
fix javadoc comment warnings (#170)
1 parent 60b09ee commit bb73af2

30 files changed

+370
-122
lines changed

src/org.hdfgroup.hdfview/hdf/HDFVersions.java

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,31 @@ public class HDFVersions {
2121
}
2222
}
2323

24-
/** @return the property to track the current versions of java */
24+
/**
25+
* Get the property to track the current versions of java
26+
*
27+
* @return the property to track the current versions of java
28+
*/
2529
public static String getPropertyVersionJava() { return props.getProperty("JAVA_VERSION"); }
2630

27-
/** @return the property to track the current versions of hdf4 */
31+
/**
32+
* Get the property to track the current versions of hdf4
33+
*
34+
* @return the property to track the current versions of hdf4
35+
*/
2836
public static String getPropertyVersionHDF4() { return props.getProperty("HDF4_VERSION"); }
2937

30-
/** @return the property to track the current versions of hdf5 */
38+
/**
39+
* Get the property to track the current versions of hdf5
40+
*
41+
* @return the property to track the current versions of hdf5
42+
*/
3143
public static String getPropertyVersionHDF5() { return props.getProperty("HDF5_VERSION"); }
3244

33-
/** @return the property to track the current versions of hdfview */
45+
/**
46+
* Get the property to track the current versions of hdfview
47+
*
48+
* @return the property to track the current versions of hdfview
49+
*/
3450
public static String getPropertyVersionView() { return props.getProperty("HDFVIEW_VERSION"); }
3551
}

src/org.hdfgroup.hdfview/hdf/view/DataView/DataView.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,10 @@ public abstract interface DataView {
3232
/** The image view type */
3333
public static final int DATAVIEW_IMAGE = 2;
3434

35-
/** @return the data object displayed in this data viewer */
35+
/**
36+
* Get the data object displayed in this data viewer
37+
*
38+
* @return the data object displayed in this data viewer
39+
*/
3640
public abstract HObject getDataObject();
3741
}

src/org.hdfgroup.hdfview/hdf/view/DataView/DataViewManager.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,11 @@ public abstract interface DataViewManager {
6767
*/
6868
public abstract void showError(String errMsg);
6969

70-
/** @return the current TreeView */
70+
/**
71+
* Get the current TreeView
72+
*
73+
* @return the current TreeView
74+
*/
7175
public abstract TreeView getTreeView();
7276

7377
/**

src/org.hdfgroup.hdfview/hdf/view/DefaultFileFilter.java

Lines changed: 70 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,8 @@ public DefaultFileFilter(String[] filters, String description)
112112
}
113113

114114
/**
115+
* Get the file extensions associated with this DefaultFileFilter
116+
*
115117
* @return the file extensions associated with this DefaultFileFilter
116118
*/
117119
public String getExtensions()
@@ -160,8 +162,10 @@ public void addExtension(String extension)
160162
}
161163

162164
/**
163-
* @return the human readable description of this filter. For example:
164-
* "JPEG and GIF Image Files (*.jpg, *.gif)"
165+
* Get the human readable description of this filter. For example: "JPEG and GIF Image Files (*.jpg,
166+
* *.gif)"
167+
*
168+
* @return the human readable description of this filter.
165169
*/
166170
public String getDescription()
167171
{
@@ -220,15 +224,19 @@ public void setExtensionListInDescription(boolean b)
220224
}
221225

222226
/**
223-
* @return whether the extension list (.jpg, .gif, etc) should show up in
224-
* the human readable description.
227+
* Check if the extension list (.jpg, .gif, etc) should show up in the human readable description.
225228
*
226-
* Only relevent if a description was provided in the constructor or using
227-
* setDescription();
229+
* @return whether the extension list (.jpg, .gif, etc) should show up in the human readable description.
230+
*
231+
* Only relevent if a description was provided in the constructor or using setDescription();
228232
*/
229233
public boolean isExtensionListInDescription() { return useExtensionsInDescription; }
230234

231-
/** @return a file filter for HDF4/5 file. */
235+
/**
236+
* Get the file filter for HDF4/5 file
237+
*
238+
* @return a file filter for HDF4/5 file.
239+
*/
232240
public static DefaultFileFilter getFileFilter()
233241
{
234242
// update extensions
@@ -242,7 +250,11 @@ public static DefaultFileFilter getFileFilter()
242250
return filter;
243251
}
244252

245-
/** @return a file filter for NetCDF3 file. */
253+
/**
254+
* Get a file filter for NetCDF3 file
255+
*
256+
* @return a file filter for NetCDF3 file.
257+
*/
246258
public static DefaultFileFilter getFileFilterNetCDF3()
247259
{
248260
DefaultFileFilter filter = new DefaultFileFilter();
@@ -252,7 +264,11 @@ public static DefaultFileFilter getFileFilterNetCDF3()
252264
return filter;
253265
}
254266

255-
/** @return a file filter for HDF4 file. */
267+
/**
268+
* Get a file filter for HDF4 file
269+
*
270+
* @return a file filter for HDF4 file.
271+
*/
256272
public static DefaultFileFilter getFileFilterHDF4()
257273
{
258274
DefaultFileFilter filter = new DefaultFileFilter();
@@ -264,7 +280,11 @@ public static DefaultFileFilter getFileFilterHDF4()
264280
return filter;
265281
}
266282

267-
/** @return a file filter for HDF5 file. */
283+
/**
284+
* Get a file filter for HDF5 file
285+
*
286+
* @return a file filter for HDF5 file.
287+
*/
268288
public static DefaultFileFilter getFileFilterHDF5()
269289
{
270290
DefaultFileFilter filter = new DefaultFileFilter();
@@ -275,7 +295,11 @@ public static DefaultFileFilter getFileFilterHDF5()
275295
return filter;
276296
}
277297

278-
/** @return a file filter for JPEG image files. */
298+
/**
299+
* Get a file filter for JPEG image files
300+
*
301+
* @return a file filter for JPEG image files.
302+
*/
279303
public static DefaultFileFilter getFileFilterJPEG()
280304
{
281305
DefaultFileFilter filter = new DefaultFileFilter();
@@ -290,7 +314,11 @@ public static DefaultFileFilter getFileFilterJPEG()
290314
return filter;
291315
}
292316

293-
/** @return a file filter for TIFF image files. */
317+
/**
318+
* Get a file filter for TIFF image files
319+
*
320+
* @return a file filter for TIFF image files.
321+
*/
294322
public static DefaultFileFilter getFileFilterTIFF()
295323
{
296324
DefaultFileFilter filter = new DefaultFileFilter();
@@ -301,7 +329,11 @@ public static DefaultFileFilter getFileFilterTIFF()
301329
return filter;
302330
}
303331

304-
/** @return a file filter for PNG image files. */
332+
/**
333+
* Get a file filter for PNG image files
334+
*
335+
* @return a file filter for PNG image files.
336+
*/
305337
public static DefaultFileFilter getFileFilterPNG()
306338
{
307339
DefaultFileFilter filter = new DefaultFileFilter();
@@ -311,7 +343,11 @@ public static DefaultFileFilter getFileFilterPNG()
311343
return filter;
312344
}
313345

314-
/** @return a file filter for BMP image files. */
346+
/**
347+
* Get a file filter for BMP image files
348+
*
349+
* @return a file filter for BMP image files.
350+
*/
315351
public static DefaultFileFilter getFileFilterBMP()
316352
{
317353
DefaultFileFilter filter = new DefaultFileFilter();
@@ -322,7 +358,11 @@ public static DefaultFileFilter getFileFilterBMP()
322358
return filter;
323359
}
324360

325-
/** @return a file filter for GIF image files. */
361+
/**
362+
* Get a file filter for GIF image files
363+
*
364+
* @return a file filter for GIF image files.
365+
*/
326366
public static DefaultFileFilter getFileFilterGIF()
327367
{
328368
DefaultFileFilter filter = new DefaultFileFilter();
@@ -332,7 +372,11 @@ public static DefaultFileFilter getFileFilterGIF()
332372
return filter;
333373
}
334374

335-
/** @return a file filter for GIF, JPEG, BMP, or PNG image files. */
375+
/**
376+
* Get a file filter for GIF, JPEG, BMP, or PNG image files
377+
*
378+
* @return a file filter for GIF, JPEG, BMP, or PNG image files.
379+
*/
336380
public static DefaultFileFilter getImageFileFilter()
337381
{
338382
DefaultFileFilter filter = new DefaultFileFilter();
@@ -351,7 +395,11 @@ public static DefaultFileFilter getImageFileFilter()
351395
return filter;
352396
}
353397

354-
/** @return a file filter for text file. */
398+
/**
399+
* Get a file filter for text file
400+
*
401+
* @return a file filter for text file.
402+
*/
355403
public static DefaultFileFilter getFileFilterText()
356404
{
357405
DefaultFileFilter filter = new DefaultFileFilter();
@@ -362,7 +410,11 @@ public static DefaultFileFilter getFileFilterText()
362410
return filter;
363411
}
364412

365-
/** @return a file filter for binary file. */
413+
/**
414+
* Get a file filter for binary file
415+
*
416+
* @return a file filter for binary file.
417+
*/
366418
public static DefaultFileFilter getFileFilterBinary()
367419
{
368420
DefaultFileFilter filter = new DefaultFileFilter();

src/org.hdfgroup.hdfview/hdf/view/HelpView/HelpView.java

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,16 @@ public abstract interface HelpView {
2626
public abstract void show();
2727

2828
/**
29-
* @return the HelpView's label, which is displayed in the HDFView
30-
* help menu.
29+
* Get the HelpView's label, which is displayed in the HDFView help menu.
30+
*
31+
* @return the HelpView's label
3132
*/
3233
public abstract String getLabel();
3334

34-
/** @return the action command for this HelpView. */
35+
/**
36+
* Get the action command for this HelpView.
37+
*
38+
* @return the action command for this HelpView.
39+
*/
3540
public abstract String getActionCommand();
3641
}

src/org.hdfgroup.hdfview/hdf/view/ImageView/ImageView.java

Lines changed: 30 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,16 +33,32 @@ public abstract interface ImageView extends DataView {
3333
*/
3434
public abstract Rectangle getSelectedArea();
3535

36-
/** @return true if the image is a truecolor image. */
36+
/**
37+
* Check if the image is a truecolor image.
38+
*
39+
* @return true if the image is a truecolor image.
40+
*/
3741
public abstract boolean isTrueColor();
3842

39-
/** @return true if the image interlace is plane interlace. */
43+
/**
44+
* Check if the image interlace is plane interlace.
45+
*
46+
* @return true if the image interlace is plane interlace.
47+
*/
4048
public abstract boolean isPlaneInterlace();
4149

42-
/** @return array of selected data */
50+
/**
51+
* Get the array of selected data
52+
*
53+
* @return array of selected data
54+
*/
4355
public abstract Object getSelectedData();
4456

45-
/** @return the image displayed in this imageView */
57+
/**
58+
* Get the image displayed in this imageView
59+
*
60+
* @return the image displayed in this imageView
61+
*/
4662
public abstract Image getImage();
4763

4864
/**
@@ -52,7 +68,11 @@ public abstract interface ImageView extends DataView {
5268
*/
5369
public abstract void setImage(Image img);
5470

55-
/** @return the palette of the image */
71+
/**
72+
* Get the palette of the image
73+
*
74+
* @return the palette of the image
75+
*/
5676
public abstract byte[][] getPalette();
5777

5878
/**
@@ -62,6 +82,10 @@ public abstract interface ImageView extends DataView {
6282
*/
6383
public abstract void setPalette(byte[][] palette);
6484

65-
/** @return the byte array of the image data */
85+
/**
86+
* Get the byte array of the image data
87+
*
88+
* @return the byte array of the image data
89+
*/
6690
public abstract byte[] getImageByteData();
6791
}

src/org.hdfgroup.hdfview/hdf/view/TableView/DataProviderFactory.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -565,7 +565,9 @@ public int getRowCount()
565565
public final void setIsValueChanged(boolean isChanged) { isValueChanged = isChanged; }
566566

567567
/**
568-
* @return if the datavalue has chaged
568+
* Check if the datavalue has changed
569+
*
570+
* @return if the datavalue has changed
569571
*/
570572
public final boolean getIsValueChanged() { return isValueChanged; }
571573

src/org.hdfgroup.hdfview/hdf/view/TableView/DefaultBaseTableView.java

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1268,13 +1268,23 @@ public int getSelectedColumnCount()
12681268
return selectionLayer.getSelectedColumnPositions().length;
12691269
}
12701270

1271-
/** @return the selection layer */
1271+
/**
1272+
* Get the selection layer
1273+
*
1274+
* @return the selection layer
1275+
*/
12721276
public SelectionLayer getSelectionLayer() { return selectionLayer; }
12731277

1274-
/** @return the data layer */
1278+
/**
1279+
* Get the data layer
1280+
*
1281+
* @return the data layer
1282+
*/
12751283
public DataLayer getDataLayer() { return dataLayer; }
12761284

1277-
/** refresh the data table */
1285+
/**
1286+
* refresh the data table
1287+
*/
12781288
@Override
12791289
public void refreshDataTable()
12801290
{
@@ -2821,7 +2831,7 @@ public void open()
28212831
colButton = new Button(content, SWT.RADIO);
28222832
colButton.setFont(curFont);
28232833
colButton.setText("Column");
2824-
colButton.setLayoutData(new GridData(SWT.CENTER, SWT.FILL, false, false));
2834+
colButton.setLayoutData(new GridData(SWT.FILL, SWT.FILL, false, false));
28252835
colButton.addSelectionListener(new SelectionAdapter() {
28262836
@Override
28272837
public void widgetSelected(SelectionEvent e)
@@ -2834,7 +2844,7 @@ public void widgetSelected(SelectionEvent e)
28342844
rowButton = new Button(content, SWT.RADIO);
28352845
rowButton.setFont(curFont);
28362846
rowButton.setText("Row");
2837-
rowButton.setLayoutData(new GridData(SWT.CENTER, SWT.FILL, false, false));
2847+
rowButton.setLayoutData(new GridData(SWT.FILL, SWT.FILL, false, false));
28382848
rowButton.addSelectionListener(new SelectionAdapter() {
28392849
@Override
28402850
public void widgetSelected(SelectionEvent e)

0 commit comments

Comments
 (0)