Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove react-motion dep #299

Open
lipp opened this issue Apr 19, 2017 · 1 comment
Open

remove react-motion dep #299

lipp opened this issue Apr 19, 2017 · 1 comment

Comments

@lipp
Copy link
Contributor

lipp commented Apr 19, 2017

No description provided.

@zemirco
Copy link
Contributor

zemirco commented Jul 25, 2017

I've written some pull requests to remove react-motion.

It worked great until the last PR which is dealing with the select component. We simply cannot animate a component which is new to the DOM. We either have to hide it before or decide to get rid of the animation. However hiding it created some issues with keyboard accessibility.

We could use react transition group https://facebook.github.io/react/docs/animation.html instead which would allow us to use CSS animations instead of JS animations like it is now with react-motion.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants