Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Axum to 0.7 #3610

Open
tisonkun opened this issue Mar 29, 2024 · 11 comments
Open

Upgrade Axum to 0.7 #3610

tisonkun opened this issue Mar 29, 2024 · 11 comments
Assignees

Comments

@tisonkun
Copy link
Collaborator

What type of enhancement is this?

Tech debt reduction, Other

What does the enhancement do?

Sooner or later we should upgrade it. I'd create this ticket to collect information, since this upgrade is a huge breaking changes from axum side - https://github.com/tokio-rs/axum/releases/tag/axum-v0.7.0

Implementation challenges

No response

@tisonkun
Copy link
Collaborator Author

tisonkun commented Mar 29, 2024

Blocked by tonic uses http 0.2 and axum 0.6.

Ref - hyperium/tonic#1595

@tisonkun
Copy link
Collaborator Author

tisonkun commented Apr 7, 2024

@yurivict
Copy link

What is holding this?

@tisonkun
Copy link
Collaborator Author

@yurivict This is mainly blocked by hyperium/tonic#1670.

@tisonkun
Copy link
Collaborator Author

tisonkun commented Jul 8, 2024

tonic 0.12 has been released. We can move forward now.

@tisonkun
Copy link
Collaborator Author

tisonkun commented Jul 8, 2024

substrait's prost version needs bump also.

@tisonkun
Copy link
Collaborator Author

tisonkun commented Jul 8, 2024

greptime-proto's patch - GreptimeTeam/greptime-proto#181

@tisonkun
Copy link
Collaborator Author

Blocked by

I'm afraid that we cannot upgrade until September's Arrow & DataFusion release and we catch up to it.

I don't know if the upgrade can be done separated, but at least cannot as a whole.

cc @waynexia @MichaelScofield

@shuiyisong
Copy link
Contributor

Some updates on this issue. Arrow and Dafafusion have both merged the corresponding PR. We'll wait for our dependency on Arrow to be updated to v53 and then we can start doing the upgrade.

cc @waynexia

Ref

  1. bump tonic to 0.12 and prost to 0.13 for arrow-flight apache/arrow-rs#6041
  2. Update to arrow/parquet 53.0.0, tonic, prost, object_store, pyo3 apache/datafusion#12032

@waynexia
Copy link
Member

💯 I'm preparing the migration to arrow 53 and the latest datafusion

@MichaelScofield
Copy link
Collaborator

💯 I'm preparing the migration to arrow 53 and the latest datafusion

@waynexia Are you still working on this? I've encountered a grpc request timeout issue, and am trying to upgrade tonic and hyper to see there are any free lunch. Our tonic and hyper are too old to waste the efforts to tackle problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants