Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function changes need for Bazel #13

Open
aydinmetee opened this issue Sep 7, 2023 · 0 comments
Open

Function changes need for Bazel #13

aydinmetee opened this issue Sep 7, 2023 · 0 comments

Comments

@aydinmetee
Copy link

Hi, I tried to use this library in Bazel. But in build process, Some files couldn't find. In my opinion, It's related to build process in bazel.
We can replace "readDir" function with "readdirSync". I forked the project and replace the function. "readdirSync" function can be more effective for asyncron process. I made some tests and I saw no error.
I can use forked version. But I think, if we replace the function, It will be more useful.
What do you think about this?

for (const entry of await readdir(dir, { withFileTypes: true })) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant