Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev project bulk atac2 #1390

Open
wants to merge 4 commits into
base: release_1.0.2
Choose a base branch
from
Open

Dev project bulk atac2 #1390

wants to merge 4 commits into from

Conversation

rcorces
Copy link
Collaborator

@rcorces rcorces commented Apr 19, 2022

Addressing #1379

Issues with projectBulkATAC() when dimsToUse has been set.

rcorces added 4 commits April 15, 2022 09:29
rbind fails if mat isnt a sparseMatrix. this change makes safeSubset flexible to accept either matrix or dgCMatrix input
the params section of ArchRProj@embeddings needs to be a list rather than a vector. If a vector, when you try to pass a vector to dimsToUse, you cant have a vector of a vector so this gets converted to dimsToUse1, dimsToUse2, dimsToUse3 etc instead of dimsToUse = c(1,2,3). Discussed in #1379 (comment)
dimsToUse has to be the intersection of the dimensions that pass corCutOff and the dimensions originally listed in dimsToUse. also, the column subsetting of simRD has to happen before the second if statement to check if the dimensions match, otherwise this if statement will always fail and exit with an error
@rcorces rcorces requested a review from jeffmgranja April 19, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant