-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove widget export feature #19340
Remove widget export feature #19340
Conversation
…-enterprise/issue-19339
…-enterprise/issue-19339
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just added some suggestions related to the wording.
message="Migrate export widget feture to enterprise" | ||
|
||
issues=["19339", "graylog-plugin-enterprise#7272"] | ||
pulls=["19340", "graylog-plugin-enterprise#7273"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in feture
.
Since this feature has never release, wouldn't it make sense to just move change log in #19140 to the enterprise repo and not add a change log in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds like we are removing the message widget export feature from open source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should just remove the changelog snippet in core, because the change is not affecting anything that has been shipped before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also remove issue-19139.toml
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dennisoelkers About issue-19139.toml we moved the messages export action to icon. Maybe it makes sense to keep at least that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense, yes!
const Explanation = () => ( | ||
<span>Export Aggregation widget feature is available for the enterprise version. | ||
Graylog provides option to export your data into most popular file formats such as | ||
CSV, JSON, YAML, XML etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't Aggregation
be lowercase?
I think either provides an option
or provides options
sounds a bit better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about:
Exporting widget results is an enterprise-only feature. With an enterprise license, you can export your results as Excel (xlsx), CSV, JSON, YAML or XML.
Please [click here] for more details.
With some helpful link included.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, works fine!
Description
This PR
Using our plugin system faces a couple of problems:
We already have actions from enterprise (fe switch to log view action) that we place into the dropdown menu and now we have to add them into the menu as well. We would like to keep only already existing
views.widgets.actions
. To be able to separate actions by position we extendWidgetActionType
. Now it has a propposition
where we can define where exactly we would like to render it. We also add newcomponent
props there. We use it instead ofaction
andtitle
to render the action component. So now we can useaction
andtitle
ORcomponent
props to renderaction.
we have to keep exporting for the messages widget. We add export messages action component into our plugins
views.widgets.actions
in the core.and we have to add the plug only for the non-enterprise users. To do that we provide
ExportWidgetAction
with positionmenu
andExportWidgetActionDelegate
as a component.ExportWidgetActionDelegate
looks atviews.components.widgets.exportAction
entity. If there is no component to render it renders a plugMotivation and Context
fix: #19339
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
/jenkins-pr-deps https://github.com/Graylog2/graylog-plugin-enterprise/pull/7273