Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Glide with Coil #365

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Replace Glide with Coil #365

wants to merge 2 commits into from

Conversation

t895
Copy link
Contributor

@t895 t895 commented Apr 13, 2024

Closes #352

@muhomorr
Copy link
Member

What's the impact on release APK size?

@topminipie
Copy link

topminipie commented Apr 18, 2024

2.7 megabytes commit 262277c
2.8 megabytes this PR

@t895
Copy link
Contributor Author

t895 commented Apr 18, 2024

@topminipie Is right. I just ran a couple builds and got these results for APK size.
main - 2759KBs
coil - 2895KBs

@muhomorr
Copy link
Member

What are the advantages of switching to Coil?

@t895
Copy link
Contributor Author

t895 commented Apr 19, 2024

I generally prefer to use Coil in my Android apps nowadays because of the Kotlin-first syntax. Working with it in the Dolphin, Citra, and yuzu Android apps has been very plesant whether it be for loading images with the built-in options or creating custom loaders for the job.

As for performance or special features, I don't know of any advantages Coil has over Glide.

@thestinger
Copy link
Member

It sounds like Coil is a nicer library, but we're just unsure if we want to move when it increases app size slightly without really offering any advantages for us. We'll need to think about it.

@thestinger
Copy link
Member

Glide is still maintained. If it wasn't, it would be an easy decision to replace an unmaintained library.

@t895
Copy link
Contributor Author

t895 commented Apr 19, 2024

That's fair
I'll just leave this open if you ever become interested in it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from Glide to Coil
4 participants