Skip to content

review-with-filter includes already reviewed items #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srl295 opened this issue Jul 31, 2021 · 0 comments
Open

review-with-filter includes already reviewed items #70

srl295 opened this issue Jul 31, 2021 · 0 comments

Comments

@srl295
Copy link

srl295 commented Jul 31, 2021

#47 fixed #29 (thanks!) in the as-yet-unreleased (?) 1.3.0 stream

However, using tasksh> review proj:HappyFunBall shows reviewed, completed, even deleted tasks for review.

Looking at the code, review-with-filter bypasses the _reviewed report and its filter entirely (It would be better named _unreviewed, but that's besides the point).

So, practically, if I want to review only one project's tasks, I would need to do:

tasksh> review proj:HappyFunBall and ( reviewed.none: or reviewed.before:now-6days ) and ( +PENDING or +WAITING )

Ideas of ways forward:

  1. Could there be a way to review using an alternate report? Then I could have:

tasksh> review _reviewed_hfb where there is report._reviewed_hfb.filter=proj:HappyFunBall and (reviewed.none: … 

  1. Could there be a default concatenation to the filter given? something like this:
tasksh.custom_filter_suffix=and ( reviewed.none: or reviewed.before:now-6days ) and ( +PENDING or +WAITING )

then tasksh> review proj:HappyFunBall would automatically concatenate the custom_filter_suffix stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant