-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tracking] import_expression doesn't function correctly in 3.12 #228
Comments
Would you prefer fixing the upstream package or redoing the logic internally? I ask because I’ve written a proof of concept for a shorter version of the same functionality. It isn’t as rigorously tested as |
Jishaku was originally going to have this feature be internal anyway. The main reason why it's in another package is because at some point I rambled about what my requirements and vision for the feature was publicly, and the maintainer took it as a challenge and built it as a standalone package so that it could be reused. Unfortunately, I don't have a good conventional means of communication with the maintainer anymore, and even back when I did they were increasingly inactive as time went on. While fixing it upstream would probably be for the best (because it would retroactively fix old jishaku versions), it's coming up on 4 years since the last I'd gladly merge any PRs that can handle the behavior on 3.12 as long as it passes the litmus test on 3.8-3.12 and doesn't break tracebacks or submodule resolution (e.g. |
Hi, I'm active again and am working on fixing this upstream. |
Closes Gorialis#231 Closes Gorialis#228
Closes Gorialis#231 Closes Gorialis#228
import_expression
does spooky AST magic to get imports to be inlined through a specialized syntax:module!
.This doesn't work anymore in 3.12 due to parser changes within Python, need to think if there is a sensible solution.
The text was updated successfully, but these errors were encountered: