Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nvidia driver installer daemonsets for cos and ubuntu to co-exist #138

Open
saswatac opened this issue Jun 17, 2020 · 0 comments
Open

Comments

@saswatac
Copy link

saswatac commented Jun 17, 2020

For clusters having both cos and ubuntu based nodes, it is needed to install both the daemonsets for ubuntu and cos, but with the current setup, only either of them can be installed.

Proposal to allow both the daemonset to be installed -

Make the changes below to preloaded daemonsets https://github.com/GoogleCloudPlatform/container-engine-accelerators/blob/master/nvidia-driver-installer/ubuntu/daemonset-preloaded.yaml and https://github.com/GoogleCloudPlatform/container-engine-accelerators/blob/master/nvidia-driver-installer/cos/daemonset-preloaded.yaml

-> replace the name and labels from "nvidia-driver-installer" to "nvidia-driver-installer-{cos/ubuntu}"

-> add an additional node selector term

nodeSelectorTerms:
            - matchExpressions:
              - key: cloud.google.com/gke-accelerator
                operator: Exists
              - key: cloud.google.com/gke-os-distribution
                operator: In
                values:
                  - {ubuntu/cos}

I will be happy to create to a PR if this sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant