Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show/Hide Shortcut not surfaced in Chrome #556

Open
skube opened this issue Apr 19, 2022 · 2 comments
Open

Show/Hide Shortcut not surfaced in Chrome #556

skube opened this issue Apr 19, 2022 · 2 comments
Labels
🔥 enhancement New feature or request ¿ question ? Further information is requested

Comments

@skube
Copy link

skube commented Apr 19, 2022

By default, one can Alt + Shift + D to show/hide VisBug. This shortcut can be been be seen while hovering over the extension icon (i.e. the tooltip).

However, when using Google Chrome and modifying the shortcut via chrome://extensions/shortcuts the tooltip doesn't update to reflect the current shortcut.

It's a little thing—I'm not even sure if it's possible to fix in this project. ❤️

@argyleink
Copy link
Collaborator

oh interesting! let me forward this on to some folks 👍🏻

@argyleink argyleink added 🔥 enhancement New feature or request ¿ question ? Further information is requested labels Apr 19, 2022
@dotproto
Copy link
Contributor

Yeah, you can use chrome.commands.getAll() (MDN) to retireve an array of commands that the extension has registered. If there's a collision with a command's shortcut, the shortcut property for that command will be an empty string.

argyleink added a commit that referenced this issue Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 enhancement New feature or request ¿ question ? Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants