Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement link checking workflow #46

Open
5 tasks
matthiasrohmer opened this issue Jan 25, 2023 · 4 comments
Open
5 tasks

Implement link checking workflow #46

matthiasrohmer opened this issue Jan 25, 2023 · 4 comments
Assignees

Comments

@matthiasrohmer
Copy link
Collaborator

matthiasrohmer commented Jan 25, 2023

Part of #45. Implement a link checking workflow, that checks for broken links on a page. Ideally the tool only runs on the changed page in a PR (to safe time and prevent positives on files unrelated to the PR) but is also able to check the full site - ideally not statically but served via our own express app.

As mentioned in #45, the problem spans wider than just broken links: we also want to make sure every page we generate is also discoverable (say linked, see GoogleChrome/developer.chrome.com#83) on the site and we also want to make sure our external sources are not broken.

  • Start a product requirements doc (PRD), evaluating and documenting possible existing tools and their pros/cons (https://github.com/untitaker/hyperlink, https://github.com/lycheeverse/lychee, ...) with the goals mentioned above in mind
  • Implement the checking logic in this repo (for example as a gulp task)
  • Add task as a workflow to d.c.c
  • Add task as a workflow to web.dev
  • Fix existing broken links
@mollietokyo
Copy link
Collaborator

Estimate for dev = 8 days (SPR-3)

@Blazzike
Copy link
Collaborator

awaiting PR review: GoogleChrome/developer.chrome.com#5667

@mollietokyo
Copy link
Collaborator

spoke with Matthias, he's waiting on internal updates prior to marking this one as 'done'

@Dexcanada1
Copy link

.editorconfig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🧐 In Review
Development

No branches or pull requests

4 participants