Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glossary: Match by glossary terms already suffixed #1794

Open
pedro-mendonca opened this issue Feb 21, 2024 · 1 comment · May be fixed by #1795
Open

Glossary: Match by glossary terms already suffixed #1794

pedro-mendonca opened this issue Feb 21, 2024 · 1 comment · May be fixed by #1795
Labels
[Type] Enhancement A suggestion for improvement.

Comments

@pedro-mendonca
Copy link
Member

What problem does this address?

Since #1373 it's possible to match terms to similar words, depending of the rules set for each part_of_speech.
Currently the match only works if the glossary entry is the base term, for nouns it must be in the singular form, and for verbs in infinitive.
If a noun glossary term is introduced in plural form, or a verb is not in infinitive, it will only match the exact terms, not being able revert to the base form and match any other cases.

What is your proposed solution?

Before try to match to suffixed terms, try to match the term to a suffixed form and use the same rules to revert to the base form. And afterwards, proceed the same by matching any possible suffixed terms.

@pedro-mendonca pedro-mendonca added the [Type] Enhancement A suggestion for improvement. label Feb 21, 2024
@tobifjellner
Copy link
Contributor

In Slack I read an idea to try and match both ways: to also have plural forms match singular entries.

I'd advise against that.

If we raise the ways things can be matched, we'll get more false positives, possibly creating disturbance and confusion.

Asking the locale teams to check that their glossary lists English terms in infinitive and singular is a one-time effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants