[Suggestion]: provide details about what was added/deleted during sync

[umlaeute]

Suggestion

the sync is super (and amazingly fast).

however, i'm pretty new to Passy and when I synched my two devices today, I got this on the connecting client:

Entries added: 0
Entries removed: 0

and that on the host:

Entries added: 6
Entries removed: 2

Now, I did add a new password (possibly consisting of multiple entries), so the Entries added line looks right.
However, I do not remember having removed anything, so I have a slightly uneasy feeling about the Entries removed line.

It would be great if I could

• check which entries have been added/removed after the sync
• possibly undo the sync (immediately after the fact; so there shouldn't be a need to go through explicit backup steps)

i know next to nothing, so if this is already possible, please tell me :-)

Submission checklist

• I have specified my suggestion in the issue title

[GleammerRay]

Hello @umlaeute !

I'm glad that synchronization works fast. It will be optimized even more with the next update.

When it comes to deleted entries, if you have added and then deleted an entry on one device before synchronization, that will count as deletion on both devices because of how Passy history operates. I must assure that synchronization is as safe as possible and there's many checks in place to prevent any accidental deletions. Undoing deletion is not very easy to implement for the time being.

You might be interested in #9 (the version control style history feature) instead. It both offers greater data retention than manual synchronization cancelation and is safer and more extensible as well.

I hope that you enjoy Passy!

[GleammerRay]

I forgot to note that entry version control is not yet implemented, it is a priority feature for after the next release.

[umlaeute]

is it already possible to find out what has been synched?

today i did a sync between two machines, my laptop and my desktop pc (both running v1.8.0 from flatpak). i think the latter never successfully synced with neither my laptop nor my phone; iirc there were no entries on this machine, but i might have played around a few months ago, with adding and removing them.

in any case, i finally managed to sync them, and on my laptop, i got this (i still have the window open):

Entries added: 0
Entries removed: 1

whereas on the desktop pc, i got something like (this is from the top of my hat, as unfortunately the info is gone by now):

Entries added: 13
Entries removed: 1

so again, I'm slightly concerned about what got added.

the sync log (on the PC) are very anonymous:

Connecting to a 2.0.0+ synchronization server... done.
Receiving users list... done.
Processing next user... done.
Receiving remote credentials metadata... done.
Authenticating... done.
Receiving hashes... done.
Comparing history hashes... done.
Receiving history entries... done.
Comparing history entries... done.
Sending entries... done.
Receiving entries... done.
Processing entries... done.
Comparing favorites hashes... 
All done.
Disconnecting... done.

it would be fantastic if:

• the logs contained at least the number of added/removed/modified entries
• it would be possible to somehow access the information which "accounts" have been added/removed/modified, so I can double check that everything is still there.

it's easy to trust in your software if you write it yourself, but for me its a black box and it might be quite catastrophic if I lost certain credentials.

[GleammerRay]

Hello @umlaeute !

I'm slightly concerned about what got added.

In Entries added: x, x is the number of total entries added and modified. At the moment, it's not easily possible to check which entries already exist during synchronization without sacrificing synchronization performance and security.

I'm currently getting Passy ready for its Play Store release so I will be adding various informational and UX improvements. I remember about this issue, and I'm thinking of replacing the simplistic sync summary UI Passy currently has with a list of entries that were added and removed (nicknames + green plus/red minus icons) and a details button underneath to reveal the full log (end of which will display said list in text without graphics). This would also make the synchronization error log snackbar obsolete, which is good as currently it disappears after a few seconds, making it harder to report synchronization bugs.

[umlaeute]

I'm slightly concerned about what got added.

In Entries added: x, x is the number of total entries added and modified.

actually that was a typo on my side.

I'm slightly concerned about what got removed

[GleammerRay]

I'm slightly concerned about what got removed

While unfortunately I can no longer promise to provide the entry version control as a part of the next update, I do intend to implement a way for you to see the exact changes that were made on both ends so that you may restore your account if you accidentally made any changes you dont want anymore.

[GleammerRay]

Synchronization details implemented in 2666a07