-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heroku SSL termination breaks Transport Security for downloads #163
Comments
I am getting NSURLErrorDomain, code=-1022 when I try to use autoUpdater which I have traced back to this issue as well. Any luck resolving it? |
I've just patched my instance to force https for the time being |
@Eugeny Hmm odd, I patched it partially it seems as now I am getting "updates available" but then afterwards am receiving the NSURLErrorDomain message before the download completes / begins. I am running it from a heroku server and have my domain set as: Potentially has to do with a redirect occuring from the URL above to: Any ideas why it would all of a sudden be OK with the URL in the beginning (whereas before I wasn't even getting to "checking for updates") and then error for the download portion? |
@Joshandrews43 check whether your URLs have https:// via the debug endpoint: The feed URL format is |
@Eugeny Just solved my problem. I did end up using https, however I just got other errors afterwards. Turns out I had to install the application as a .dmg file to my computer and then issue updates to the heroku server as a .zip otherwise they wouldn't download (on mac). Not sure why; any idea? |
For people running into this issue it can be solved by setting |
When deploying to Heroku, the download URLs will use http:// instead of https:// as
getFullUrl()
uses req.protocol, which is always 'http' on HerokuThe text was updated successfully, but these errors were encountered: