Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Gallery component do not have images and message prop's value as they are undefined #1435

Open
khushal87 opened this issue Jun 2, 2022 · 2 comments
Labels
Documentation Related to Docs Internal Backlog Moved to our internal backlog

Comments

@khushal87
Copy link
Member

Describe the bug
The images and message prop in the Gallery component is undefined on the console. If we follow the example:

const CustomGallery = ({ images, onPressIn }) => {
  console.log(images);

  return (/** Your custom UI */)
}

in here you will get the value of images undefined. Moreover, the message prop on the console is also undefined.

Dev environment info (please complete/provide the following information):

The latest version of the SDK has the problem

To Reproduce
Steps to reproduce the behavior:

  1. Create a custom component as in the example.
  2. Try consoling the images and message prop in the Gallery custom component.
  3. You get undefined consoled.

Expected behavior
It should console and have the images and the message object. Having a context explicitly might solve the issue but I believe the props should have the value too. The props should align against the Typescript too.

Additional context
Nil

Screenshots
Nil

@khushal87 khushal87 added Needs Triaging Bug Something isn't working in the SDK and removed Needs Triaging labels Jun 2, 2022
@vanGalilea
Copy link
Contributor

@vanGalilea
Copy link
Contributor

Let's update the docs so it'll be clear to our customers to use contexts over props

@vanGalilea vanGalilea added Documentation Related to Docs and removed Bug Something isn't working in the SDK labels May 24, 2023
@vishalnarkhede vishalnarkhede added the Internal Backlog Moved to our internal backlog label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Related to Docs Internal Backlog Moved to our internal backlog
Projects
None yet
Development

No branches or pull requests

3 participants